WordPress.org

Make WordPress Core

Opened 7 years ago

Closed 5 years ago

Last modified 5 years ago

#16047 closed enhancement (fixed)

Post formats should have its own column on edit.php, hidden by default

Reported by: nacin Owned by: markjaquith
Milestone: 3.6 Priority: normal
Severity: normal Version:
Component: Post Formats Keywords: has-patch needs-testing
Focuses: Cc:

Description

Post Formats currently are displayed in the title row.

Ideally, they should be their own column. This column should be hidden by default. (Doing this, I've found, is not particularly easy given how we currently handle columns.)

NB: We should consider requesting an icon set from Ben as well, now that we're out of v1 for the feature.

I'm committing a quick fix to clean up how they are currently displayed in the title row.

Attachments (14)

16047.diff (1.1 KB) - added by nacin 7 years ago.
Quick fix for 3.1.
16047.2.diff (3.0 KB) - added by garyc40 7 years ago.
Post format on a separate column, hidden by default
16047.3.diff (2.2 KB) - added by garyc40 7 years ago.
Don't use a separate user option
16047.4.diff (2.1 KB) - added by DrewAPicture 5 years ago.
Refresh.
16047.5.diff (2.2 KB) - added by wonderboymusic 5 years ago.
16047.6.diff (1.3 KB) - added by aaroncampbell 5 years ago.
16047.7.diff (1.5 KB) - added by markjaquith 5 years ago.
16047.8.diff (1.4 KB) - added by aaroncampbell 5 years ago.
16047.9.diff (811 bytes) - added by markjaquith 5 years ago.
posts-post-table-columns.patch (716 bytes) - added by azaozz 5 years ago.
16047.10.diff (3.4 KB) - added by helen 5 years ago.
post-formats-icons.zip (11.6 KB) - added by helen 5 years ago.
Screen Shot 2013-03-20 at 9.21.50 PM.png (26.8 KB) - added by helen 5 years ago.
16047.11.diff (3.5 KB) - added by helen 5 years ago.

Download all attachments as: .zip

Change History (48)

#1 @nacin
7 years ago

  • Type changed from defect (bug) to enhancement

@nacin
7 years ago

Quick fix for 3.1.

#2 @nacin
7 years ago

For the 3.1 patch, which is fine to Jane: http://cl.ly/212g3O0n172M2x3f3x00

Currently: http://cl.ly/1j0A2O3F3L3n1e3S1V12

#3 @nacin
7 years ago

(In [17191]) Small visual improvements to post formats on edit.php. see #16047.

@garyc40
7 years ago

Post format on a separate column, hidden by default

#4 @garyc40
7 years ago

  • Keywords has-patch needs-testing added; needs-patch removed

In order to hide post format column by default, I have to add another user option. Other than that, the patch is pretty straightforward.

On another note, should we add a filter hook somewhere in get_hidden_columns() ? That would make hiding Post format column a little bit cleaner.

#5 @nacin
7 years ago

  • Keywords needs-patch added; has-patch needs-testing removed

Ideally, it should be possible for any plugin to hide a column by default. We don't want a new user option here, especially not specific to post formats.

Meta boxes can be hidden by default. The same approach, ideally, should be taken.

@garyc40
7 years ago

Don't use a separate user option

#6 @garyc40
7 years ago

  • Keywords has-patch needs-testing added; needs-patch removed

Ideally, this should be ideal :)

#7 @mikeschinkel
7 years ago

  • Cc mikeschinkel@… added

#8 @sbressler
6 years ago

  • Cc sbressler@… added
  • Keywords 3.2-early removed

Any update on this?

#9 @helen
5 years ago

  • Milestone changed from Future Release to 3.6

#11 @sabreuse
5 years ago

  • Cc sabreuse added

#12 @WraithKenny
5 years ago

  • Cc Ken@… added

#13 @rachelbaker
5 years ago

  • Cc rachelbaker added

#14 @helen
5 years ago

  • Keywords needs-refresh added

@DrewAPicture
5 years ago

Refresh.

#15 @DrewAPicture
5 years ago

  • Keywords needs-refresh removed

#16 @aaroncampbell
5 years ago

I think we decided to allow post formats regardless of current_theme_supports( 'post-formats' ), so we should probably remove those checks

#17 follow-up: @wonderboymusic
5 years ago

Yep, removed in latest attached patch

#18 in reply to: ↑ 17 @aaroncampbell
5 years ago

Replying to wonderboymusic:

Yep, removed in latest attached patch

Thanks. I think we should take it one step further and make the column visible by default. We're trying to bring formats into focus, so let's do it all the way. Done in 16047.6.diff

@markjaquith
5 years ago

#19 @markjaquith
5 years ago

.7 outputs 'Standard' for standard posts, which technically have no format.

#20 @aaroncampbell
5 years ago

Guess I should have refreshed the ticket first. Mark beat me to it - .7 and .8 are exactly the same.

#21 @markjaquith
5 years ago

  • Owner set to markjaquith
  • Resolution set to fixed
  • Status changed from new to closed

In 23392:

Display post formats in the posts list table.

props nacin, garyc40, DrewAPicture, wonderboymusic, aaroncampbell.

fixes #16047

#22 follow-up: @nacin
5 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

Compelled to re-open this for a few reasons:

  1. This is UI cruft if a user's theme doesn't support post formats, and never has. I disagree with "I think we should take it one step further and make the column visible by default. We're trying to bring formats into focus, so let's do it all the way." As discussed in IRC last week, there are ways to make post formats visible without shoving them into the faces of all WordPress users, including those who have zero need for them. We discussed making it so tabs don't show up by default in some circumstances. The same should occur for this.
  1. In lieu of a column, distinct images representing each format is likely more effective than text labels, given this is not super-important information and cannot (or should not be able to be) changed via quick edit.
  1. Is showing the word "Standard" over and over necessary? What about just a simple — dash? We now do that for no tags and no categories, rather than showing "No tags" and "Uncategorized" every time. It's cleaner and seems to be working.
  1. If we do have text, it should be clickable to filter down posts of that format. ?post_format= does work in the admin, we made sure of that back in 3.1 if I recall correctly.

#23 in reply to: ↑ 22 @DrewAPicture
5 years ago

Replying to nacin:

Compelled to re-open this for a few reasons:

  1. This is UI cruft if a user's theme doesn't support post formats, and never has. I disagree with "I think we should take it one step further and make the column visible by default. We're trying to bring formats into focus, so let's do it all the way." As discussed in IRC last week, there are ways to make post formats visible without shoving them into the faces of all WordPress users, including those who have zero need for them. We discussed making it so tabs don't show up by default in some circumstances. The same should occur for this.

I could get behind not showing the column by default.

  1. In lieu of a column, distinct images representing each format is likely more effective than text labels, given this is not super-important information and cannot (or should not be able to be) changed via quick edit.

Perhaps related? #23333 (New icons)

  1. Is showing the word "Standard" over and over necessary? What about just a simple — dash? We now do that for no tags and no categories, rather than showing "No tags" and "Uncategorized" every time. It's cleaner and seems to be working.

I think we should just not show anything if there's no post format set. The 'standard' keyword is used a lot in themes when doing a content loop but it's odd outside of that context.

  1. If we do have text, it should be clickable to filter down posts of that format. ?post_format= does work in the admin, we made sure of that back in 3.1 if I recall correctly.

I think #15323 covers this (Filter by post format in wp-admin/edit)

@markjaquith
5 years ago

#24 @markjaquith
5 years ago

.8 links it (for non-standard ones, as standard links don't work), uses a dash for standard.

Agree with point 2 in nacin's comment, but we don't have those images yet.

#25 @helen
5 years ago

Replying to nacin:

  1. In lieu of a column, distinct images representing each format is likely more effective than text labels, given this is not super-important information and cannot (or should not be able to be) changed via quick edit.

You can change it via quick edit. Should probably remove that: #23426. Otherwise, I am fine with an icon, probably in the title column; we just don't have icons yet.

  1. Is showing the word "Standard" over and over necessary? What about just a simple — dash? We now do that for no tags and no categories, rather than showing "No tags" and "Uncategorized" every time. It's cleaner and seems to be working.

I said yes because of having the column on by default. If not (not on by default or not a column/just icons), then no.

#26 @aaroncampbell
5 years ago

I agree that icons would be better. When the icons are done let's ditch the column and add them to the title column.

#27 @markjaquith
5 years ago

In 23396:

Link post formats in posts list table. Use a dash for standard, like we do for absence of tags. see #16047 Next: use icons, not text descriptions.

#28 @azaozz
5 years ago

As the posts table is "fixed" adding another column without setting width doesn't scale well on narrower screens. The above patch fixes that and tweaks the other columns widths.

#29 @helen
5 years ago

  • Component changed from Administration to Post Formats

#30 @markjaquith
5 years ago

Just waiting on icons here, then we can lose the column.

@helen
5 years ago

#31 @helen
5 years ago

16047.10.diff, needs post-formats-icons.zip. Screenshot below; tested 2x icon placement in iOS simulator, wouldn't mind somebody looking on an actual HiDPI display.

http://core.trac.wordpress.org/raw-attachment/ticket/16047/Screen%20Shot%202013-03-20%20at%209.21.50%20PM.png

@helen
5 years ago

#32 @helen
5 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 23765:

Lose the added column for post formats in the posts list table and add an icon before the title instead. Icons are clickable to filter the list table down to posts of that post type and format. props melchoyce for the icons. fixes #16047.

#33 @helen
5 years ago

For the record, it was decided to place the icon before the title for scanning and clicking ease:

http://f.cl.ly/items/3i2Y3C0J1x203p3e0S13/Screen%20Shot%202013-03-20%20at%2011.07.49%20PM.png

#34 @helen
5 years ago

In 24426:

Change the post format icons sprite to be vertical rather than horizontal in order to allow it to be used for wider items such as labels. RTL tweak for the icon in the posts list table. See #16047, #24519.

Note: See TracTickets for help on using tickets.