WordPress.org

Make WordPress Core

Opened 9 years ago

Closed 6 years ago

#16055 closed defect (bug) (wontfix)

Only fire 'Site Wide Only' plugin header deprecated notice if the plugin is activated

Reported by: nacin Owned by:
Milestone: Priority: normal
Severity: normal Version: 3.0
Component: Plugins Keywords: has-patch 2nd-opinion
Focuses: Cc:
PR Number:

Description

Apparently it can be fired on a deactivated plugin. That's annoying and confusing.

Attachments (1)

16055-1.patch (803 bytes) - added by DJPaul 9 years ago.

Download all attachments as: .zip

Change History (5)

@DJPaul
9 years ago

#1 @DJPaul
9 years ago

  • Keywords has-patch added

#2 @nacin
6 years ago

  • Keywords 2nd-opinion added; 3.2-early removed

Coming back to this, I'm not actually sure if this is a bad thing after all. The notice is clear about which plugin it is. In general, these notices are annoying anyway — I don't think if this plugin was activated would it be any less annoying or confusing. And because plugins can be activated on *other* sites in a network, it's kinda important to make sure the header is up to date and not using deprecated behavior.

A note on the stale patch here — that change in the conditional also affects $plugin_data['Network'] = $plugin_data['_sitewide'];, which would still need to apply in case the plugin was inactive.

Any thoughts, DJPaul, as a BuddyPress (which is Network: true) core dev?

#3 @DrewAPicture
6 years ago

  • Summary changed from Only fire 'Side Wide Only' plugin header deprecated notice if the plugin is activated to Only fire 'Site Wide Only' plugin header deprecated notice if the plugin is activated

#4 @nacin
6 years ago

  • Milestone Future Release deleted
  • Resolution set to wontfix
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.