wp_kses_split2() is private, no need to create a function with the sole purpose to call a function.

[hakre]

In the effort to remove create_function() constructs from the file (#10623, #7363) the last one was removed in 16313 / #14424.

While the analysis in the last ticket was right that create_function() is not needed, the resolution to introduce a named function was not.

Infact the anonymous callback function has been replaced with a named callback function without taking into account, that a named callback function already exists. So a function whith its sole purpose to call another function has been introduced by the google summer of code student.

The existing functions name is wp_kses_split2(), having the needed properties. The function is marked as private and not used anywhere else in the file kses.php nor the whole core php code.

It can be safely adopted to fulfill the requirements of the callback function signature.

This saves the overhead of a function call per callback call.

Additionally passing the data needs only one entry in the symbol table by using an array.

[hakre]

Changeset in question: r16313 kses.php

[SergeyBiryukov]

Perhaps we can also rename the resulting wp_kses_split2() function to _wp_kses_split_callback()? Seems like a more accurate name to me.

[westi]

This changes the prototype of wp_kses_split2 in a backward incompatible way.

While it is marked private a plugin could be using it and changing the prototype would break that.

[hakre]

Replying to SergeyBiryukov:

Perhaps we can also rename the resulting wp_kses_split2() function to _wp_kses_split_callback()? Seems like a more accurate name to me.

&&

Replying to westi:

This changes the prototype of wp_kses_split2 in a backward incompatible way. ...

Both feedback has been addressed in the updated patch. Should the deprecated function move into that deprecated function file?

[hakre]

Better callback function name, Deprecate the old function.

[hakre]

And what about moving the Phpdocs of the old function to the new one?

[hakre]

Phpdocs moved.