Make WordPress Core

Opened 13 years ago

Closed 13 years ago

Last modified 10 years ago

#16063 closed defect (bug) (fixed)

Update network notification is only shown in the site admin

Reported by: petemall's profile PeteMall Owned by:
Milestone: 3.1 Priority: normal
Severity: normal Version: 3.1
Component: Network Admin Keywords: has-patch commit
Focuses: multisite Cc:

Description

Update Network notification is only shown in the site admin instead of the network admin.
"Thank you for Updating! Please visit the Update Network page to update all your sites."

Attachments (5)

16063.diff (713 bytes) - added by PeteMall 13 years ago.
16063.number.diff (3.4 KB) - added by nacin 13 years ago.
16063.2.diff (1.3 KB) - added by PeteMall 13 years ago.
16063.3.diff (909 bytes) - added by SergeyBiryukov 13 years ago.
16063.4.diff (585 bytes) - added by Nacin 13 years ago.

Download all attachments as: .zip

Change History (16)

#1 @PeteMall
13 years ago

  • Summary changed from Update Network notification is only show in in the site admin to Update network notification is only shown in the site admin

@PeteMall
13 years ago

@nacin
13 years ago

@PeteMall
13 years ago

#2 @nacin
13 years ago

Per IRC discussion, a few things need changing here. There are four functions in ms.php that are tied to admin_notices.

We'll handle theme as follows: secret_salt in network admin, ms_deprecated_blogs_file in network admin, new_user_email_admin_notice in site admin, site_admin_notice in both. That's handled by 16063.2.diff.

Additionally, I've attached a patch to put an update # in the 'Network Admin' link, per an IRC discussion with Jane and Pete. It basically just requires us letting some things fall through from menu.php into admin-header.php. That's 16063.number.diff.

#3 @ryan
13 years ago

  • Keywords commit added

#4 @nacin
13 years ago

(In [17215]) Alter admin_notices usage in admin/includes/ms.php due to changes in the action with the network/user admin. props PeteMall, see #16063.

#5 follow-up: @nacin
13 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [17217]) Update indicator for the Network Admin link. fixes #16063.

#6 in reply to: ↑ 5 @westi
13 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

Replying to nacin:

(In [17217]) Update indicator for the Network Admin link. fixes #16063.

The number should be sprintf'd into the string or we have RTL I18N issues I believe

#8 @TobiasBg
13 years ago

After svn-updating, I get

Notice: Undefined variable: total_update_title in [.....]\wp-admin\menu.php on line 58

with WP_DEBUG on.

The variable was added in [17217] as it seems, but is not defined. The "total_" seems to be unnecessary.

#9 @nacin
13 years ago

Typo on my part, thanks. The $total_update_count was necessary because $update_count is used later in menu.php for plugins, and it was cleaner to rename this one. Not sure how total_ got prepended here too.

#10 @nacin
13 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

(In [17219]) Use correct variable. props SergeyBiryukov, TobiasBg, fixes #16063.

@Nacin
13 years ago

#11 @jeremyfelt
10 years ago

#13983 was marked as a duplicate.

Note: See TracTickets for help on using tickets.