#16063 closed defect (bug) (fixed)
Update network notification is only shown in the site admin
Reported by: | PeteMall | Owned by: | |
---|---|---|---|
Milestone: | 3.1 | Priority: | normal |
Severity: | normal | Version: | 3.1 |
Component: | Network Admin | Keywords: | has-patch commit |
Focuses: | multisite | Cc: |
Description
Update Network notification is only shown in the site admin instead of the network admin.
"Thank you for Updating! Please visit the Update Network page to update all your sites."
Attachments (5)
Change History (16)
#1
@
14 years ago
- Summary changed from Update Network notification is only show in in the site admin to Update network notification is only shown in the site admin
#8
@
14 years ago
After svn-updating, I get
Notice: Undefined variable: total_update_title in [.....]\wp-admin\menu.php on line 58
with WP_DEBUG on.
The variable was added in [17217] as it seems, but is not defined. The "total_" seems to be unnecessary.
#9
@
14 years ago
Typo on my part, thanks. The $total_update_count was necessary because $update_count is used later in menu.php for plugins, and it was cleaner to rename this one. Not sure how total_ got prepended here too.
Note: See
TracTickets for help on using
tickets.
Per IRC discussion, a few things need changing here. There are four functions in ms.php that are tied to admin_notices.
We'll handle theme as follows: secret_salt in network admin, ms_deprecated_blogs_file in network admin, new_user_email_admin_notice in site admin, site_admin_notice in both. That's handled by 16063.2.diff.
Additionally, I've attached a patch to put an update # in the 'Network Admin' link, per an IRC discussion with Jane and Pete. It basically just requires us letting some things fall through from menu.php into admin-header.php. That's 16063.number.diff.