WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

#16065 closed enhancement (wontfix)

Move db_select statement in wp-db.php 5 lines

Reported by: rohdef Owned by:
Milestone: Priority: normal
Severity: normal Version: 3.1
Component: General Keywords:
Focuses: Cc:

Description

in the function db_connect() we have the following lines:

$this->set_charset( $this->dbh );

$this->ready = true;

$this->select( $this->dbname, $this->dbh );

changing them to:

$this->select( $this->dbname, $this->dbh );

$this->set_charset( $this->dbh );

$this->ready = true;

would be a major help for people implementing other databases than mysql, since some databases require the name om the database to be part of the connection string. Eg. the PG4WP plugin only create a fake connection on the connect command and waits for the select database statement to be run.

I know it's in the details department, but for some of us it's an very important detail.

Ps. PostgreSQL support would really be appreciated. Apart from being outdated at the moment the PG4WP creates a really nice start for giving adding support for other database vendors.

Change History (1)

comment:1 @nacin4 years ago

  • Milestone Awaiting Review deleted
  • Resolution set to wontfix
  • Status changed from new to closed

You can just replace the method. That'd be safer than us needing to test the various different configurations already out there.

Note: See TracTickets for help on using tickets.