WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 3 years ago

Last modified 3 years ago

#16066 closed enhancement (fixed)

Update failed problem

Reported by: JonezJeA Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Upgrade/Install Keywords:
Focuses: Cc:

Description

I tested this with three installations of Wordpress!

  1. Put Wordpress 3.0.3 on a server.
  2. When the updating is busy, close it! (See this as a laptop battery reaching 0% or the browser chrasing for some reason)
  3. Put the update via FTP!

=> You will still get a message 'Try to update again' while you got the most recent version!
I asked what the problem was at the forums but if this is in three different installations and I did the same thing with different browsers then the problem must be at Wordpress no?

Change History (10)

comment:1 garyc404 years ago

When you stop the upgrade page while it's processing, the connection from your browser to the server is closed, and the upgrade is stopped. This is an expected behavior in all browsers.

In the Codex, it's clearly stated that you should back up the site before attempting an upgrade. It also says if the automatic upgrade doesn't work for you, you should try upgrading manually.

Or you could restore your back up and restart the auto upgrade again.

The instruction is here: http://codex.wordpress.org/Updating_WordPress

Anyways, I don't think this is a bug. It could fit as an enhancement, where WordPress automatic update remembers its progress and automatically resumes when restarted. But there are perhaps other priorities for the next major release.

Close this as wontfix?

comment:2 JonezJeA4 years ago

Meaby that enhancement is a good idea

comment:3 JonezJeA4 years ago

a wontfix is a fix for later no?

comment:4 JonezJeA4 years ago

  • Type changed from defect (bug) to enhancement

comment:5 dd324 years ago

  • Component changed from General to Upgrade/Install
  • Milestone changed from Awaiting Review to Future Release

The updater should be using ignore_user_abort(); to avoid problems of the process being severed half way through.

The fact is, version.php may have been updated in this case, but that doesn't mean that the upgrade fully completed (especially if the maintenance file has timed out by the time the user loads the site again).

This may also help on some sites that use a proxy server in front of PHP, in that there have been reports that the proxy gives up on waiting for data and returns an error..

comment:6 garyc404 years ago

I'm just curious about the side effects of using ignore_user_abort() with the updater script.

Let's say after the user aborts (whether deliberately or not), the updater process keeps running for a while. Now if the user loads the updater again before the previous updater process finishes, won't there be 2 updater processes running concurrently?

comment:7 dd324 years ago

Now if the user loads the updater again before the previous updater process finishes, won't there be 2 updater processes running concurrently?

Yes, The .maintainence file should kick in before then.. So as a extra step, I'd have to check to see where the maintainence checks are done to ensure that they cant conflict. Of course, if you started the process at the exact instance twice, then all hell would break loose, but it already does.

Luckily, You can re-upgrade a site without ill effects.

comment:8 JonezJeA4 years ago

I think it would be better when Wordpress is up to date that it doesn't ask to update anymore also in the case when it failed and you uploaded it succesfully via FTP.

comment:9 jonezjea3 years ago

  • Resolution set to fixed
  • Status changed from new to closed

I tried this in WordPress 3.2 and the problem doesn't appear anymore so maybe by fixing another bug this one is fixed.

Solved for me!

comment:10 SergeyBiryukov3 years ago

  • Milestone Future Release deleted
Note: See TracTickets for help on using tickets.