PHP4 Compat

[westi]

just installed a brand spanking new installation here:

http://nicedoggie.net/testbed

This is the error I get:

*Parse error*: syntax error, unexpected '&', expecting T_VARIABLE or '$' in
*/home/misha/public_html/testbed/wp-includes/class-wp-admin-bar.php* on line
*160*

[westi]

PHP4 compat code

[nacin]

Another:

Parse error: syntax error, unexpected '&', expecting T_VARIABLE or '$' in /home/content/w/h/e/wheat395/html/wordpress/wp-admin/includes/media.php on line 1479

Looks like we need to find our PHP4 testbeds this week :-)

[nacin]

With regards to incompatible foreach issues, a grep only finds these two.

wpgrep foreach.*\&
./wp-admin/includes/media.php:1479:foreach ( $post_params as $param => & $val )
./wp-includes/class-wp-admin-bar.php:160:		foreach( $menu as $id => &$menu_item ) {

Can probably check for parse errors across all files on a testbed for other things.

[SergeyBiryukov]

Created the patch for wp-admin/includes/media.php.

Checked all the common screens (including Network Admin) on PHP 4.4.7. Seem to work correctly.

[ryan]

(In [17211]) PHP4 compat. Props SergeyBiryukov, westi. see #16080