WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

#16082 closed defect (bug) (fixed)

Widgets Panel needs to be RTLized

Reported by: rasheed Owned by: azaozz
Milestone: 3.2 Priority: normal
Severity: normal Version: 3.1
Component: RTL Keywords: has-patch ux-feedback
Focuses: Cc:

Description (last modified by yoavf)

Snapshot: http://img577.imageshack.us/img577/9193/1212t.gif

Location: wp-admin/widgets.php (Wordpres-ar/rtl)

#widget-list .widget {

border: 0 none;
float: left; (float should be right)
margin: 0 10px 15px;
width: 250px;

}

--
Edit by yoavf: edited title to reflect new patch that RTLize the whole widgets panel

Attachments (4)

16082.patch (415 bytes) - added by SergeyBiryukov 3 years ago.
widgets-arrow-rtl.gif (168 bytes) - added by yoavf 3 years ago.
widgets-arrow-vs-rtl.gif (158 bytes) - added by yoavf 3 years ago.
widgets-rtl.patch (3.8 KB) - added by yoavf 3 years ago.
Another refresh

Download all attachments as: .zip

Change History (23)

SergeyBiryukov3 years ago

comment:1 SergeyBiryukov3 years ago

  • Keywords has-patch added; rtl css removed

yoavf3 years ago

yoavf3 years ago

comment:2 yoavf3 years ago

  • Milestone changed from Awaiting Review to 3.1
  • Owner set to yoavf
  • Status changed from new to accepted

This ticket made me realized Widgets UI has never been proprely RTLized.

Attached files fix that, finally

comment:3 follow-up: nacin3 years ago

Let's do just the float for 3.1 and hit the rest in 3.2. Touching the widgets JS is scary at this stage.

comment:4 nacin3 years ago

  • Keywords commit added

comment:5 nacin3 years ago

(In [17216]) Quick RTL CSS fix in widgets admin. see #16082, props SergeyBiryukov.

comment:6 nacin3 years ago

  • Keywords 3.2-early added
  • Milestone changed from 3.1 to Future Release

comment:7 yoavf3 years ago

  • Milestone changed from Future Release to 3.2

Refreshed patch for trunk. Would be great if we can get this in 3.2.

comment:8 yoavf3 years ago

  • Description modified (diff)
  • Summary changed from Float right required (css issue) to Widgets Panel needs to be RTLized

yoavf3 years ago

Another refresh

comment:9 in reply to: ↑ 3 ; follow-up: maor3 years ago

Replying to nacin:

Let's do just the float for 3.1 and hit the rest in 3.2. Touching the widgets JS is scary at this stage.

I agree. Touching the JS at this stage can cause problems, and it isn't worth the risk.

comment:10 in reply to: ↑ 9 yoavf3 years ago

Replying to maor:

I agree. Touching the JS at this stage can cause problems, and it isn't worth the risk.

Have you tested the patch? It's pretty straightforward.
This has already been punted from 3.1, and should really go in 3.2.

comment:11 nacin3 years ago

That was said after we were in RC in 3.1. The JS seems pretty basic ultimately.

comment:12 follow-ups: azaozz3 years ago

The full patch is good but do we really want to switch over the widgets screen about year and a half after is was released? Would probably seem strange to all RTL users.

comment:13 in reply to: ↑ 12 yoavf3 years ago

Replying to azaozz:

The full patch is good but do we really want to switch over the widgets screen about year and a half after is was released? Would probably seem strange to all RTL users.

That's a valid concern, but I think that in this case it's better late than never - it really doesn't make sense the way it currently is.

comment:14 in reply to: ↑ 12 rasheed3 years ago

Replying to azaozz:

The full patch is good but do we really want to switch over the widgets screen about year and a half after is was released? Would probably seem strange to all RTL users.

I think the current widget's structure in WordPress RTL is fine.

comment:15 westi3 years ago

  • Keywords 3.2-early removed
  • Owner changed from yoavf to azaozz
  • Status changed from accepted to assigned

azaozz please can you review this and either commit for 3.2 or punt with an explanation why.

comment:16 azaozz3 years ago

  • Keywords ux-feedback added; commit removed

Think this needs some UX feedback before we can commit. See the last comments by @yoavf and @rasheed.

comment:17 yoavf3 years ago

Just to reiterate - though it currently works, it is reversed, and doesn't match the rest of the UI.
It doesn't make sense to keep it the way it is just because it is fine. We should strive for perfection :)

comment:18 jane3 years ago

I'm with yoav. We designed the screen with a hierarchy/flow, and better late than never for it to make sense in RTL.

comment:19 azaozz3 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In [18095]:

Widgets RTL fixes, props yoavf, fixes #16082

Note: See TracTickets for help on using tickets.