_close_comments_for_old_posts should not close pages

[Otto42]

_close_comments_for_old_posts should do a check on the post_type and not apply itself to Pages.

[Otto42]

patch to not close comments on pages automatically

[ocean90]

Duplicate #16085.

[nacin]

Should this be whitelisted for posts, rather than blacklisted for pages? Should the whitelist or blacklist be filterable for CPTs?

[Otto42]

Filterable makes sense.

Whitelist vs. blacklist I have no opinion on. Either way, an in_array check on a filtered array is easy enough to do.

[westi]

IMHO it should whitelist itself and only apply to posts.

CPTs can do there own thing.

[nacin]

Here's a simple whitelist + filter solution.

[ryan]

I'll be contrary and say it should apply to all types. If I check this box it means I am lazy and don't want to moderate comments on any old content.

[markjaquith]

But the concept of "oldness" doesn't really apply to pages. They don't exist chronologically. Yeah, they have a timestamp, but they don't fade away in prominence just because their timestamp is old.

[johnjamesjacoby]

Fix missing parenthesis in 16090.diff

[johnjamesjacoby]

I agree with everyone but Ryan. Sorry friend. :)

I think custom post types should have their own comment settings for things like this, or at least have mechanisms to opt out/override.

Patch applied clean but was missing parenthesis. Refreshed in 16090.3.diff.

[westi]

In [18087]:

Only close comments on old posts by default. Fixes #16090 props nacin and johnjamesjacoby.

[nacin]

We forgot about attachments here. #19858