WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

#16093 closed defect (bug) (duplicate)

Correct search results when using pretty permalinks

Reported by: SergeyBiryukov Owned by:
Milestone: Priority: normal
Severity: normal Version: 3.1
Component: General Keywords: has-patch
Focuses: Cc:

Description

As originally reported by Vladimir Kolesnikov, search results for Cyrillic keywords are incorrect when using pretty permalinks.

When using ?s=%D1%81%D0%BB%D0%BE%D0%B2%D0%BE, the search string is decoded by PHP. When using search/%D1%81%D0%BB%D0%BE%D0%B2%D0%BE/, we should perform urldecode() ourselves.

Attachments (1)

16093.patch (558 bytes) - added by SergeyBiryukov 3 years ago.

Download all attachments as: .zip

Change History (3)

SergeyBiryukov3 years ago

comment:1 SergeyBiryukov3 years ago

  • Keywords has-patch 3.2-early added

comment:2 dd323 years ago

  • Keywords 3.2-early removed
  • Milestone Awaiting Review deleted
  • Resolution set to duplicate
  • Status changed from new to closed

Patch is bad, It double-decodes ?s=... search requests, For example, ?s=test%2520search decodes to test search.

Closing as duplicate #13961

Note: See TracTickets for help on using tickets.