WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 2 years ago

#16114 closed enhancement (fixed)

Screen options tab colors don't match background

Reported by: johnjamesjacoby Owned by: nacin
Milestone: 3.4 Priority: low
Severity: trivial Version:
Component: UI Keywords: has-patch 2nd-opinion
Focuses: Cc:

Description

The screen options tabs look a bit odd when they are rolled open. The included patch lightens them up to match the background color of the opened screen options area.

Attachments (4)

screen-options.png (23.1 KB) - added by johnjamesjacoby 3 years ago.
Screen shot
screen-options-tabs.diff (856 bytes) - added by johnjamesjacoby 3 years ago.
Changes to wp-admin.dev.css
16114.diff (2.9 KB) - added by helenyhou 2 years ago.
16114.2.diff (1.2 KB) - added by helenyhou 2 years ago.

Download all attachments as: .zip

Change History (15)

johnjamesjacoby3 years ago

Screen shot

johnjamesjacoby3 years ago

Changes to wp-admin.dev.css

comment:1 nacin3 years ago

  • Component changed from General to UI
  • Keywords 2nd-opinion ui-feedback added; 2nd-look removed
  • Type changed from defect (bug) to enhancement

Also should consider doing this for the blue theme then, as well.

comment:2 jane2 years ago

  • Keywords needs-refresh added; ui-feedback removed
  • Milestone changed from Future Release to 3.4
  • Priority changed from normal to low
  • Severity changed from normal to trivial

As it stands now in 3.3, the color is the same, but there is a dividing line between tab and main area. Would love to get rid of that per patch, but am guessing patch will need a refresh given all the help tab changes in 3.3. (And yes, blue color scheme needs same treatment as gray.)

helenyhou2 years ago

comment:3 helenyhou2 years ago

  • Keywords needs-refresh removed

16114.diff does gray and blue. Blue needed a color change in order to match.

http://f.cl.ly/items/2a1O2s2n1A0A3p1f0b30/screen-meta-links.png

comment:4 nacin2 years ago

The arrow got shifted up one pixel when the border was added. Otherwise, looks fantastic.

comment:5 chexee2 years ago

I think the arrow should be aligned to the baseline of the text and perhaps we should have a blue tinted arrow on the blue version. Otherwise, looks great :)

comment:6 nacin2 years ago

In [20076]:

Improve background, styling, and alignment of the Help and Screen Options tabs. props helenyhou. props johnjamesjacoby for initial patch. see #16114.

comment:7 nacin2 years ago

Leaving open in case chexee or helenyhou want to make blue arrows to match.

helenyhou2 years ago

comment:8 helenyhou2 years ago

16114.2.diff Boom. Also very slightly tweaks the up arrow (.screen-meta-active).

comment:9 follow-up: nacin2 years ago

You'll need to upload arrows-vs.png.

Thinking I am going to go with arrows-blue.png at this point. -vs was the initials of the person who designed the blue icons originally. It's time we just move in the direction of a more semantic direction (which is something we do for a few already).

comment:10 in reply to: ↑ 9 nacin2 years ago

Replying to nacin:

You'll need to upload arrows-vs.png.

We apparently already have an arrows-vs.png. Okay then.

comment:11 nacin2 years ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In [20082]:

Use blue arrows for blue admin's screen options and help tabs. Adjust baseline to be more compatible with Firefox. props helenyhou. fixes #16114.

Note: See TracTickets for help on using tickets.