Make WordPress Core

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#16123 closed enhancement (duplicate)

Clean up wp-admin-rtl.dev.css

Reported by: recKz Owned by:
Milestone: Priority: normal
Severity: trivial Version:
Component: RTL Keywords: has-patch
Focuses: Cc:


"In wp-admin-rtl.dev.css, there are comments that suggest the line numbers of corresponding rules in wp-admin.dev.css . However, these comment lines are outdated.

The task is to update these line numbers, and re-order the rules as necessary based on the corresponding line numbers in wp-admin.dev.css.

Sections such as Media library, TinyMcE, ltr, no italic at the bottom of the files don't need updating."


I've completed this as part of my Code In task and have attached the patch to this ticket. There were a couple of elements that I couldn't find in wp-admin.dev.css and put these in their own category at the top of the file.

Attachments (1)

wp-admin-rtl.dev.css.patch (18.9 KB) - added by recKz 3 years ago.

Download all attachments as: .zip

Change History (5)

recKz3 years ago

comment:1 garyc403 years ago

  • Keywords has-patch needs-testing added; GCI task CSS cleanup removed

Patch looks good. I gave a run through with RTL and everything looks OK.

However, still needs review from an RTL expert.

comment:2 nacin3 years ago

  • Component changed from Themes to RTL
  • Milestone changed from Awaiting Review to Future Release
  • Type changed from task (blessed) to enhancement

comment:3 yoavf3 years ago

  • Resolution set to duplicate
  • Status changed from new to closed

A rewrite of wp-admin-rtl,css has already been done in r17941 as part of the update for #17324 (admin style refresh)- so this can be closed.
This would have probably got in if the styles wouldn't have been updated for 3.2, so thanks a lot (alot even) for the contribution!

comment:4 ocean903 years ago

  • Keywords needs-testing removed
  • Milestone Future Release deleted
Note: See TracTickets for help on using tickets.