Tag cloud widget: hide dropdown when there's only one taxonomy

[GautamGupta]

We should use get_taxonomies() instead of get_object_taxonomies(). Attaching a patch. [20285]

When there's only one taxonomy to select from, we shouldn't show the dropdown at all.

[nacin]

Related: #11612. This is an additional enhancement past that.

I would love to hide the dropdown (make it input:hidden so it still saves) when there is only one taxonomy that supports a tag cloud. Less UI for the win.

[kcssm]

This ticket is 3 months old and its way before wordpress-3.1 was released, still this issue is not addressed in this new version. Hope this gets addressed in the next update to come.

[nacin]

I would love to hide the dropdown (make it input:hidden so it still saves) when there is only one taxonomy that supports a tag cloud. Less UI for the win.

Would like a patch to implement this.

[GautamGupta]

Attached another patch based on nacin's recommendations.

Should we return 'post_tag' in _get_current_taxonomy() if no taxonomy was found saved in the options?

[johnjamesjacoby]

Would be helpful for bbPress 2.0 to inherit this instead of including it's own duplicate widget.

Added the needs testing keyword as it's been 6 months since it's had attention.

[westi]

I kicked the tires on this patch and here is some feedback:

• Works nicely as I remove taxonomies till none are available.
• The text displayed in the widget when none are available could do with some copy editing to improve it.
• The whole patch could do with some work to match coding standards for things like spacing inside of function calls, around !, the whole switch statement.
• (Personal Taste) I'm not a big fan of the way the switch statement ends up laid out with all the switching back and forth between php and html. I wonder if it might read easier to use echo's instead.

Adding 'needs-refresh' to get the patch updated.

[gautamgupta]

Based on westi's recommendations

[gautamgupta]

I've attached a new patch based on westi's recommendations. I've also removed the fallback to the post tag taxonomy if no taxonomies are found as if it was hid due to some reason from the tag cloud, we should be acknowledging that.

[jane]

If this is making it into 3.3, it needs to be committed now, as we have passed freeze. If it's not ready to be committed, punt to next cycle.

[ryan]

Punting enhancements from 3.3.

[nacin]

In [20285]:

Use get_taxonomies() instead of get_object_taxonomies() in the tag cloud widget. props GautamGupta, scribu. see #20238, see #16125.

[nacin]

I unintentionally derailed this ticket in comment 2. Hence [20285].

[scribu]

Trying to salvage this ticket somehow.

[wlindley]

Grammatical error in tagcloud.v3.diff --currently:

'The tag cloud would not be displayed since their are no taxonomies...

should be 'there':

'The tag cloud would not be displayed since there are no taxonomies...

Any chance of getting at least the one-line patch from [20285] into 3.4? Without that, taxonomies cannot even use the standard Tag Cloud widget.

[SergeyBiryukov]

Replying to wlindley:

Any chance of getting at least the one-line patch from [20285] into 3.4?

Yes, it's already committed.

[wonderboymusic]

In 34273:

Widgets: don't show a dropdown if there is only 1 taxonomy or zero taxonomies available to the Tag Cloud widget form. Don't output the widget if there are no terms in the selected taxonomy.

Props GautamGupta, wonderboymusic.
Fixes #16125.