Duplicate "try again" links when themes_api fails
|Reported by:||solarissmoke||Owned by:|
When the Themes API fails, for example when searching for themes (in my case because of timed out connection to wp.org, two "Try again" links are presented to the user.
The issue is with this line in WP_Theme_Install_List_Table->prepare_items()
wp_die( $api->get_error_message() . '</p> <p class="hide-if-no-js"><a href="#" onclick="document.location.reload(); return false;">' . __( 'Try again' ) . '</a>' );
$api->get_error_message() already returns a try again link ( set by themes_api() ), but this line adds another one in addition. I suggest removing the latter? Also, there are no CSS rules of .hide-if-no-js on Error pages, so it doesn't do anything.
Change History (15)
comment:3 in reply to: ↑ 2 @solarissmoke — 4 years ago
comment:8 @solarissmoke — 4 years ago
- Keywords has-patch commit removed
- Resolution fixed deleted
- Status changed from closed to reopened
comment:12 in reply to: ↑ 11 @westi — 4 years ago
- Resolution set to fixed
- Status changed from reopened to closed