WordPress.org

Make WordPress Core

Opened 10 years ago

Closed 10 years ago

#16146 closed defect (bug) (fixed)

Remove the theme supports check when deciding post format rewrites

Reported by: nacin Owned by:
Milestone: 3.1 Priority: normal
Severity: normal Version: 3.1
Component: Rewrite Rules Keywords:
Focuses: Cc:

Description

Currently, when registering the post_format taxonomy, we check current_theme_supports('post-formats').

This introduces a problem in canonical when formats are not supported, where /type/aside/ redirects to /type/aside/?post_format=aside. In this specific case, Mark was actually registering support on init 10, which was too late for the core taxonomies at init 0. (Would need to happy on after_setup_theme.)

Instead, we should always support rewriting, and let the query 404 the page as appropriate. Thus, /type/aside/ will 404 when there are no asides, whether formats are enabled or not, and whether the aside is a supported format or not.

Change History (1)

#1 @nacin
10 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [17240]) Don't check for post format support when registering the post format taxonomy. fixes #16146.

Note: See TracTickets for help on using tickets.