"Shortlink" button in admin bar relies on shortlink meta tag to work

[solarissmoke]

If you remove the remove the action that adds <link rel="shortlink" ... into the head of a post, the shortlink button in the admin bar says "No shortlink available for this page" when you click it, even though the href for the link is a valid shortlink.

IMO the absence of the <link> does not mean that one doesn't exist (it could be announced in other ways, e.g., a HTTP header), and so the admin bar button needs to take this into account.

Maybe the clickShortlink Javascript function should check the href of the shortlink button in cases where there is no <link> tag?

[nacin]

Since it actually links to the shortlink, we should simply have it echo its own link.

[nacin]

Look at all that red :-)

At that point, we don't even need var shortlink, right? Can just do t.href?

[nacin]

Looks like we can also remove the noShortlink bit from script-loader, as the Shortlink menu item will only exist when there's a shortlink.

[SergeyBiryukov]

Replying to nacin:

At that point, we don't even need var shortlink, right? Can just do t.href?

I guess not, since after t = t.parentNode it's not a link anymore.

[nacin]

Ah, never mind on that point then.

[SergeyBiryukov]

Replying to nacin:

Looks like we can also remove the noShortlink bit from script-loader, as the Shortlink menu item will only exist when there's a shortlink.

Done.

[solarissmoke]

Just wondering, is there a reason why we don't give the Admin Bar li's an id (instead of class), and use that instead of class sniffing? I'm guessing there is, because otherwise it would be a lot simpler.

Also, the script currently adds an event handler to monitor ALL clicks in the admin bar area, even though the only one we do anything with is the shortlink button - wouldn't it be better to add the handler directly to the link? Again, there may be a reason it is done this way, just that I don't know it.

[filosofo]

Not putting id attributes on the admin menu elements avoids potential conflicts.

Also, note that the class attribute is on the li element, not the a element. The current admin bar view provides a way to put classes (and not ids) on the li elements but not the a elements.

[sillybean]

Related: #14760. (The Shortlink button appears only on posts.)

[koopersmith]

This patch makes the shortlink menu item expand when clicked (like a sub-menu when a menu item is hovered over), and automatically highlights the shortlink.

[ryan]

(In [17263]) Expand shortlink menu when clicked. Fix displayed of shortlinks when rel shortlink is missing. Props koopersmith. fixes #16155

[koopersmith]

Patch reselects shortlink when a user clicks on it, increases the shortlink container's width, and fixes a bug where hovering can be undefined.

[nacin]

(In [17265]) Admin bar shortlink improvements. props koopersmith, fixes #16155.

[ocean90]

16155.remove.script.r17263.patch: In my mind it's now cruft, so we can remove it or is there something against this?

[nacin]

(In [17313]) Stop localizing the admin bar. props ocean90, fixes #16155.