WordPress.org

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #16155, comment 8


Ignore:
Timestamp:
01/09/11 04:17:11 (5 years ago)
Author:
solarissmoke
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #16155, comment 8

    initial v1  
    1 Just wondering, is there a reason why we don't give the shorlink <a> tag an id (e.g., wp-admin-bar-shortlink), and use that instead of class sniffing? I'm guessing there is, because otherwise it would be a lot simpler. 
     1Just wondering, is there a reason why we don't give the Admin Bar li's an id (instead of class), and use that instead of class sniffing? I'm guessing there is, because otherwise it would be a lot simpler. 
    22 
    3 If there was an id, it would also mean we don't need to monitor ALL clicks in the admin bar area, even though the only one we do anything with is the shortlink button. 
     3Also, the script currently adds an event handler to monitor ALL clicks in the admin bar area, even though the only one we do anything with is the shortlink button - wouldn't it be better to add the handler directly to the link? Again, there may be a reason it is done this way, just that I don't know it. 
    44