Pagination and sorting reset after bulk media deletion

[hakre]

When doing Bulk Deletes on paginated Media Library, after performing the delete, I'm back on page 1 regardless on which page I've been before.

[ocean90]

Related: #15416

[ocean90]

Same for categories and tags page. If we have it for posts and comments (#15416), we should add it with the other pages too.

[hakre]

I was able to reproduce against latest trunk.

[hakre]

It does not reflect the sort column as well.

paged is part of the request, orderby and order are not.

[hakre]

preserve paged

[hakre]

The patch preserves paged for bulk media deletes. sorting is not preserved as it does not gets passed in the request.

The idea I had so far is to add hidden form fields or to change the forms action attribute when things are changed by javascript.

The only hotfix I know of so far is to disable javascript which makes one of the biggest improvements of 3.1 looking pretty reduced.

[SergeyBiryukov]

hakre's patch works for me.

[nacin]

Noting that ocean90 was also able to reproduce this against edit-tags.php. A few of us were looking at this today (MarkJaquith in particular) and pagination was inconsistent across a number of screens.

[SergeyBiryukov]

Tried to take a stab at it.

[SergeyBiryukov]

Looks like the Plugins screen is affected too. Are there any else?

[garyc40]

My patch over here also fixes pagination and sort reset for edit-tags, edit-comments, edit .
​garyc40.16166.2.diff

Perhaps we should merge this ticket and #16166?

[dd32]

Combining this, as the patch over on 16162 should fix this once it's applied to the rest of the list tables.

Duplicate of #16162

[ocean90]

Replying to dd32:

Combining this, as the patch over on 16162 should fix this once it's applied to the rest of the list tables.

Duplicate of #16162

s/#16162/#16166/

[ryno267]

This is still an issue and imo shouldn't be merged with the ajax ticket. Any resolution to this

[scribu]

Yeah, need to handle this either way.

[ericlewis]

This has been fixed for the Edit Media list, but is still a problem on the tags and categories page.

This is because the <form>'s method attribute is set to post, rather than get, which ends up throwing off wp_get_referer(), losing the paged parameter in the link. attachment:16162.diff​ fixes the form method.

[wonderboymusic]

In 29782:

In the form handler logic for edit-tags.php, don't redirect until $_REQUEST['paged'] has been checked. All switch cases (except edit) now use break instead of exit.

Fixes #16162.