Media Library Bulk Delete: Error in deleting...

[hakre]

While Bulk Deletion, when a user gets the "Error in deleting..." message, there is no information given of how many elements have been deleted so far.

Let's say there was a bulk of N deletions, getting this error can mean up to N-1 items have been deleted already.

Same is the case if for some item, no permissions are granted to delete it. The number of successfully deleted items is missing as well.

[westi]

I guess this probably needs applying to all bulk actions.

Moving to Future for now - no Patch yet.

[solarissmoke]

This patch reports exactly which items failed to trash/untrash/delete for bulk edits.

[bpetty]

I have attached an updated patch against latest SVN trunk. Besides updating it though, I also made 3 fixes to the old patch.

1. Added esc_html filter for titles in error messages (required for security).
2. Fixed usage of WP_Error so it doesn't add a blank error first incorrectly (when there is at least one error).
3. The get_post() check actually needed to be negated in order to properly skip over items that were in fact deleted already, and also so that bulk item deletion actually worked properly (the original patch made it impossible to delete items using bulk deletion).

This patch, like the original, is a fix for both #16165 as well as #16164.

[nacin]

Related w/r/t better error messages, #19826.

[nacin]

Looks good. If you try to delete a few hundred posts and they all fail for some reason, is it necessary to error that every one of them couldn't be deleted? At some point should we just show a number, if count( $errors ) is too high, or if there were no successes at all?

[bpetty]

New patch added that only shows the count of the number of items that failed if it's greater than 10 items. Also fixed some spacing to adhere to coding guidelines.

[scribu]

From the patch:

// Escape item titles displayed in error messages. 
add_filter( 'the_title', 'esc_html' );

Why is that needed?

And I agree with Westi that we should handle this for all list screens. Punting.

[bpetty]

Replying to scribu:

From the patch:

// Escape item titles displayed in error messages. 
add_filter( 'the_title', 'esc_html' );

Why is that needed?

These are error messages, not post previews, and the wp_die() page they end up on don't even have the same styles set for either the current theme or wp-admin which would result in displaying them in yet a third, completely different way then the user is expecting to see them. Here, we're only concerned about the user identifying the corresponding post that failed, not display it.

That, and it's one less place to worry about CSRF if it were ever a problem in post titles (not saying the post edit pages don't already trust titles with markup, but limiting the locations this is exposed is still ideal).

[nacin]

#16164 was marked as a duplicate.