WordPress.org

Make WordPress Core

Opened 3 years ago

Last modified 8 months ago

#16180 reopened enhancement

In Add an Image, Link URL should be empty if Size = Full Size

Reported by: novasource Owned by:
Milestone: Awaiting Review Priority: normal
Severity: normal Version: 3.0.4
Component: Media Keywords: close
Focuses: Cc:

Description

In the Add an Image dialog, Link URL should be empty if Size is Full Size. This is because there is no value in adding a link to an image if the original, unmolested version is being displayed.

You may need to be selective about how to implement this enhancement. Examples:

  • If Full Size was not the default selection when the dialog loaded, then it may not be right to remove the Link URL field if the Size radio button is changed to Full Size.
  • If Full Size was the default selection when the dialog loaded, and this is the dialog produced just after uploading an image, then the Link URL field probably should stay empty unless someone selects a different selection for Size.

Change History (7)

comment:1 SergeyBiryukov3 years ago

Link URL may lead to another address. Related: #13429.

comment:2 novasource3 years ago

Correct, which is why I recommended selectiveness in implementation. I guess my beef is there is probably no purpose in a link back to the image if Full Size is selected.

comment:3 c3mdigital9 months ago

  • Keywords close added
  • Resolution set to invalid
  • Status changed from new to closed

Users link to other things besides just the full size img. Many link to other urls or blog posts so this is invalid.

comment:4 helen9 months ago

  • Milestone Awaiting Review deleted

comment:5 follow-up: novasource9 months ago

  • Resolution invalid deleted
  • Status changed from closed to reopened

@c3mdigital: I think you're misunderstanding what I am saying. I am NOT recommending that we get rid of the link functionality. I am saying that in certain situations, the link to a full size version of the image is pointless and should not be inserted by default. Nothing in my request prevents links to other things; in fact, by not inserting pointless links by default, WordPress would reduce the steps to make useful links to other things.

comment:6 dd328 months ago

  • Milestone set to Awaiting Review

comment:7 in reply to: ↑ 5 c3mdigital8 months ago

Replying to novasource:

@c3mdigital: I think you're misunderstanding what I am saying. I am NOT recommending that we get rid of the link functionality. I am saying that in certain situations, the link to a full size version of the image is pointless and should not be inserted by default. Nothing in my request prevents links to other things; in fact, by not inserting pointless links by default, WordPress would reduce the steps to make useful links to other things.

I understand where you're coming from. This would need javascript to change the link select based on what image size is chosen. I think the default should always be none personally but I know that it might frustrate a lot of users who are used to the image linking to the larger size. I normally change the default in a plugin or theme setup function. We need to make decisions on tickets like this or we are never going to get the backlog of 3000 manageable.

Note: See TracTickets for help on using tickets.