Make WordPress Core

Opened 14 years ago

Closed 14 years ago

#16187 closed defect (bug) (fixed)

Page Number Jumps after Bulk Action

Reported by: hakre's profile hakre Owned by:
Milestone: 3.1 Priority: normal
Severity: normal Version: 3.1
Component: General Keywords: has-patch needs-testing
Focuses: Cc:


I was on page X where X != 1, then I step down to page 1. Then I bulk delete all entries (100). After deletion I am on page 8 of 4 (?!).

Probably related to the other bulk update table navigation problems.

Attachments (4)

16187-after-bulk.png (45.8 KB) - added by hakre 14 years ago.
16187.diff (1.2 KB) - added by greuben 14 years ago.
16187.002.diff (1.3 KB) - added by markjaquith 14 years ago.
16187-3.diff (3.5 KB) - added by greuben 14 years ago.

Download all attachments as: .zip

Change History (13)

#1 @hakre
14 years ago

This is a bit tricky to reproduce. I have this in Chrome with JS on.

First of all, I navigate to:

You need to have at least more than one page to trigger this. In my case this will display page 8 of 7.

Then I use the arrow buttons next to the paged textbox on top of the table to move to page 1.

Even the URL in Chromes address field now has paged=1 instead of 8, after performing a bulk action, I come back to paged=8.

Version 0, edited 14 years ago by hakre (next)

#2 @nacin
14 years ago

  • Milestone changed from Awaiting Review to 3.1

#3 @greuben
14 years ago

checking paged against total pages is a simple fix.

14 years ago

#4 @markjaquith
14 years ago

Attachments was missing the redirect that posts and comments have if paged is greater than the maximum number of pages. Did that... so that takes care of going directly to the URL. Then took the second part of greuben's patch, which should enforce it via AJAX.

Please test!

#5 @garyc40
14 years ago

  • Keywords has-patch needs-testing added

#6 @nacin
14 years ago

(In [17271]) Force get_pagenum to validate max pages. Add sanity redirect code to upload.php. see #16187. props MarkJaquith, greuben.

#7 @nacin
14 years ago

We need to go through the other list tables to see where else that redirect code needs to end up.

14 years ago

#8 @greuben
14 years ago

Attached a patch where this redirect is needed except for users list table and mu users list able.

For both users list table we rely on paged arg for offset which returns zero results in this case total_pages cannot be calculated.

#9 @markjaquith
14 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [17274]) Add "paged param is greater than total pages" redirects to a few more screens. props greuben. fixes #16187

Note: See TracTickets for help on using tickets.