Make WordPress Core

Opened 10 years ago

Closed 10 years ago

Last modified 9 years ago

#1619 closed defect (bug) (fixed)

Tab highlight issue

Reported by: eragle Owned by: ryan
Milestone: Priority: lowest
Severity: trivial Version: 1.5.2
Component: Administration Keywords: bg|has-patch
Focuses: Cc:


Go to Manage / Manage Pages.
Now jump back to Write.
You are at the Write Post page, but the Write Page tab is highlighted by accident.

Attachments (2)

pagemenu.diff (500 bytes) - added by skeltoac 10 years ago.
pagemenu.2.diff (504 bytes) - added by skeltoac 10 years ago.
This one!

Download all attachments as: .zip

Change History (9)

comment:1 @schulte10 years ago

  • Resolution set to fixed
  • Status changed from new to closed

If you comment out line 26 of wp-admin/post.php, this menu tab issue goes away.

	// Fix submenu highlighting for pages.
//if (false !== strpos($_SERVER['HTTP_REFERER'], 'edit-pages.php')) $submenu_file = 'page-new.php';

What I don't know is if you remove that code, does something else get jammed up elsewhere...might be some remnant code.

comment:2 @schulte10 years ago

  • Keywords bg|2nd-opinion added
  • Resolution fixed deleted
  • Status changed from closed to reopened

comment:3 @markjaquith10 years ago

Really dumb. but we should probably create page-post.php that does something like:

$this_is_a_page = true;

comment:4 @ryan10 years ago

  • Milestone changed from 1.5.2 to 1.6

@skeltoac10 years ago

comment:5 @skeltoac10 years ago

  • Keywords bg|has-patch added; bg|2nd-opinion removed
  • Owner changed from anonymous to ryan
  • Status changed from reopened to new

Oops, grabbed that out of the wrong working copy :-)

Here ya go. Use the second one.

@skeltoac10 years ago

This one!

comment:6 @ryan10 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [3164]) Tab highlight fix from skeltoac. fixes #1619

comment:7 @anonymous9 years ago

  • Milestone 2.0 deleted

Milestone 2.0 deleted

Note: See TracTickets for help on using tickets.