Make WordPress Core

Opened 21 years ago

Closed 21 years ago

Last modified 20 years ago

#1619 closed defect (bug) (fixed)

Tab highlight issue

Reported by: eragle Owned by: ryan
Priority: lowest Milestone:
Component: Administration Version: 1.5.2
Severity: trivial Keywords: bg|has-patch
Cc: Focuses:

Description

Go to Manage / Manage Pages.
Now jump back to Write.
You are at the Write Post page, but the Write Page tab is highlighted by accident.

Attachments (2)

pagemenu.diff​ (500 bytes ) - added by skeltoac 21 years ago.
pagemenu.2.diff​ (504 bytes ) - added by skeltoac 21 years ago.
This one!

Download all attachments as: .zip

Change History (9)

#1 @schulte
21 years ago

  • Resolution → fixed
  • Status new → closed

If you comment out line 26 of wp-admin/post.php, this menu tab issue goes away.

	// Fix submenu highlighting for pages.
//if (false !== strpos($_SERVER['HTTP_REFERER'], 'edit-pages.php')) $submenu_file = 'page-new.php';

What I don't know is if you remove that code, does something else get jammed up elsewhere...might be some remnant code.

#2 @schulte
21 years ago

  • Keywords bg|2nd-opinion added
  • Resolution fixed
  • Status closed → reopened

#3 @markjaquith
21 years ago

Really dumb. but we should probably create page-post.php that does something like:

$this_is_a_page = true;
include('post.php');

#4 @ryan
21 years ago

  • Milestone 1.5.2 → 1.6

@skeltoac
21 years ago

#5 @skeltoac
21 years ago

  • Keywords bg|has-patch added; bg|2nd-opinion removed
  • Owner changed from anonymous to ryan
  • Status reopened → new

Oops, grabbed that out of the wrong working copy :-)

Here ya go. Use the second one.

@skeltoac
21 years ago

This one!

#6 @ryan
21 years ago

  • Resolution → fixed
  • Status new → closed

(In [3164]) Tab highlight fix from skeltoac. fixes #1619

#7 @(none)
20 years ago

  • Milestone 2.0

Milestone 2.0 deleted

Note: See TracTickets for help on using tickets.