"Available themes" is empty/confusing when there are no other themes installed

[solarissmoke]

When there are no alternative themes installed, wp-admin/themes.php just has <h3>Available Themes</h3> followed by an empty table. I think this can be a bit confusing (and it looks a bit weird as well).

It might be better to say something like "you have no other themes installed at the moment. You can [link to theme-install.php] search for themes here." And to not create an empty table.

[solarissmoke]

Don't show empty "available themes" table, and link to theme-install.php

[garyc40]

use display_rows_or_placeholder() for themes-list-table and theme-install-list-table, also fixed some css inconsistencies in theme-install-list-table

[garyc40]

before css and display_rows_or_placeholder() fix

[garyc40]

after css and display_rows_or_placeholder() fix

[garyc40]

also fix empty (hidden) tablenav on themes.php when total_pages <= 1

[garyc40]

tablenav was output but display:none with height:30px

[garyc40]

removed tablenav altogether when total_pages <= 1

[dd32]

3.2 may include a review of the UI screens related to this

[nacin]

The main thing here is a regression. The code was written and is in the list table no less.

Please see my attached patch (I found this ticket after) for my simple fix, at least.

[nacin]

Sad panda.

[solarissmoke]

Do we still need to print an empty table at the bottom - or could we move $wp_list_table->display(); to before the elseif ?

[nacin]

We would need to check to make sure it's not a search I think -- see the start of that. I didn't dig too deep into the logic, I just remember doing all the strings in no_items() and was very surprised to not see them echo'd.

I don't even want to check what happens when a search returns no results. It looks like no_items() gets called, and no_items() currently doesn't take into account searching and the like. :-(

[solarissmoke]

Replying to nacin:

This patch sorts out those issues and I think it is consistent with the generic behaviour of WP_List_Table. The output of no_items() looks a bit funky IMO, but that is a styling issue which garyc40 has provided a suggestion for.

[garyc40]

Checked all other outputs of no_items(). Seems like WP_Themes_List_Table is the only one we need to account for searching.

[nacin]

Patch tested and looks good. And thanks Gary for checking.

[ryan]

(In [17303]) Improve presentation when there are no available themes. Props solarissmoke, garyc40. fixes #16196