WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 2 years ago

Last modified 19 months ago

#16206 closed defect (bug) (wontfix)

Commenttext not marked as required

Reported by: infected Owned by:
Milestone: Priority: normal
Severity: normal Version: 3.0.4
Component: Comments Keywords: has-patch 2nd-opinion
Focuses: Cc:

Description

I thought i already opened a ticket to this but i cant find it... Maybe i didnt hit the create ticket button?!

When using comment_form() the name and email fields marked as required while the textarea for commenttext is not. If i send my comment without text i'll get this notice

Error: please type a comment.

So it also should be marked as required field.

Attachments (1)

16206.patch (2.0 KB) - added by solarissmoke 4 years ago.
Mark comment field as required

Download all attachments as: .zip

Change History (12)

comment:1 @dd324 years ago

  • Keywords 3.2-early needs-patch added; comment commenttext required removed
  • Milestone changed from Awaiting Review to Future Release

Sounds like a good idea, Kind of should be consistent in the forms :)

@solarissmoke4 years ago

Mark comment field as required

comment:2 @solarissmoke4 years ago

  • Keywords has-patch added; needs-patch removed

comment:3 @nacin4 years ago

Looks like maybe my comment either got stopped by dd32's, or I was commenting to the other phantom ticket. Looks like the former.

Anyway, I don't mind adding aria-required, but the * seems just redundant and silly. Mentioned it to MarkJaquith and a few others and I seemed to recall them nodding in agreement on that.

comment:4 @nacin4 years ago

  • Keywords 2nd-opinion added; 3.2-early removed

Ah, comment text already has aria-required.

comment:5 follow-up: @infected4 years ago

My opinion: Either the field is required (the error notice is saying that) then the * isn´t redundant, otherwise it isn´t a required field. Maybe the code already has an aria-required but visitors don´t look into the code for required fields. ;-)

Last edited 4 years ago by infected (previous) (diff)

comment:6 in reply to: ↑ 5 ; follow-ups: @SergeyBiryukov4 years ago

Replying to infected:

Maybe the code already has an aria-required but visitors don´t look into the code for required fields. ;-)

I guess in the case of a comment text that's just implied by common sense.

comment:7 in reply to: ↑ 6 @infected4 years ago

Replying to SergeyBiryukov:

I guess in the case of a comment text that's just implied by common sense.

From this point of view, yes. It's just a cosmetic thing...

comment:8 in reply to: ↑ 6 @MikeHansenMe2 years ago

  • Cc mdhansen@… added
  • Keywords close added

Replying to SergeyBiryukov:

Replying to infected:

Maybe the code already has an aria-required but visitors don´t look into the code for required fields. ;-)

I guess in the case of a comment text that's just implied by common sense.

I would agree that the comment field is common sense. Proposing close

comment:9 @SergeyBiryukov2 years ago

  • Keywords close removed
  • Milestone Future Release deleted
  • Resolution set to wontfix
  • Status changed from new to closed

comment:10 @ocean9019 months ago

#25384 was marked as a duplicate.

comment:11 @nofearinc19 months ago

Based on reports from confused newbie clients, I'd also vote +1 for adding the asterisk for the comment field.

Note: See TracTickets for help on using tickets.