WordPress.org

Make WordPress Core

Changes between Version 1 and Version 2 of Ticket #16215, comment 19


Ignore:
Timestamp:
01/23/2013 11:17:23 PM (5 years ago)
Author:
adamsilverstein
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #16215, comment 19

    v1 v2  
    2222things to consider:
    2323
    24 * is using menu_order for revisions a good idea? better approach? here were comments from original patch "I took the menu_order approach outlined above in the ticket, but used comment_count instead since a page's menu_order is actually versioned by the revisioning system. This comment_count trick won't work if plugins (or future core) allow comments on revisions. As an alternative, we could hack the version into post_name." any other input here or leave as is?
     24* is using comment_count for revisions a good idea? will we ever want comments on revisions? any good ideas for another approach?
     25
     26here were comments from original patch "I took the menu_order approach outlined above in the ticket, but used comment_count instead since a page's menu_order is actually versioned by the revisioning system. This comment_count trick won't work if plugins (or future core) allow comments on revisions. As an alternative, we could hack the version into post_name."
     27
     28any other input here or leave as is? 
     29
    2530* address this issue from original ticket?:  "Currently, post_modified is identical to post_date, which is the time the post was put into the state represented by the revision. We could make post_modified the time the post was edited away from the state represented by the revision." comments? is this issue in the post or in the revisions? move to another ticket
    2631