Hide core updater if running an svn checkout

[johnjamesjacoby]

The logic with this patch is if you are running an svn checkout, do not display the core updater code and instead display a reminder.

[koopersmith]

Having some sort of svn-specific behavior is definitely something we should do, but disabling the core updater entirely seems error prone. It should just be a warning.

[scribu]

What koop said.

Also, we should do the same per plugin/theme at some point.

[solarissmoke]

How does this do for a simple warning?

[dd32]

I'd throw an ABSPATH in there at least. Someone else might like to weigh in on the wording.

[scribu]

Wouldn't is_directory() be more appropriate?

[solarissmoke]

Wouldn't is_directory() be more appropriate?

Yeah, I suppose it would, have changed it.

[nacin]

I believe WordPress is spelled wrong here :-)

[solarissmoke]

Everyone's allowed to make that mistake once, right? :P

[scribu]

Since we're at it, how about checking for a .git directory too? :D

[solarissmoke]

Add ABSPATH, use is_dir(), and capital P, dangit!

[solarissmoke]

There we go. I thought about customising the string for SVN and Git, but it seems like overkill.

[nacin]

If we are to offer Git checkout detection, which I'm not inclined to do, I'd rather not combine the string.

Also, let's spell out "Subversion". My take: <strong>Warning:</strong> It appears that you are running Subversion checkout of WordPress. You may wish to keep WordPress up to date using Subversion instead.

Also, please don't replace patches -- just upload new ones.

[solarissmoke]

Also, please don't replace patches -- just upload new ones.

Okay.

[dd32]

If we are to offer Git checkout detection, which I'm not inclined to do

I agree here, Support the VCS we're using, we can't support every single VCS out there..

[dd32]

attachment warning.jpg added

• demo of 16216.3.diff for UI feedback.

[jane]

Missed freeze, punting.

[helen]

I know we disable auto updates when a VCS is detected - is that reusable here in any way?

[chriscct7]

This would make for a great enahancement