WordPress.org

Make WordPress Core

Opened 10 years ago

Last modified 17 months ago

#16216 new enhancement

Hide core updater if running an svn checkout

Reported by: johnjamesjacoby Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Upgrade/Install Keywords: has-patch needs-refresh
Focuses: ui Cc:

Description

The logic with this patch is if you are running an svn checkout, do not display the core updater code and instead display a reminder.

Attachments (5)

running-svn-co.patch (3.6 KB) - added by johnjamesjacoby 10 years ago.
16216.diff (768 bytes) - added by solarissmoke 10 years ago.
16216.2.diff (820 bytes) - added by solarissmoke 10 years ago.
Add ABSPATH, use is_dir(), and capital P, dangit!
16216.3.diff (796 bytes) - added by solarissmoke 10 years ago.
warning.jpg (74.1 KB) - added by dd32 10 years ago.

Download all attachments as: .zip

Change History (23)

#1 @koopersmith
10 years ago

  • Component changed from General to Upgrade/Install
  • Keywords 3.2-early added
  • Milestone changed from Awaiting Review to Future Release

Having some sort of svn-specific behavior is definitely something we should do, but disabling the core updater entirely seems error prone. It should just be a warning.

#2 @scribu
10 years ago

  • Keywords 3.2-early removed
  • Milestone changed from Future Release to 3.2

What koop said.

Also, we should do the same per plugin/theme at some point.

Last edited 10 years ago by scribu (previous) (diff)

@solarissmoke
10 years ago

#3 @solarissmoke
10 years ago

  • Keywords has-patch added

How does this do for a simple warning?

#4 @dd32
10 years ago

  • Keywords ui-feedback added

I'd throw an ABSPATH in there at least. Someone else might like to weigh in on the wording.

#5 @scribu
10 years ago

Wouldn't is_directory() be more appropriate?

#6 @solarissmoke
10 years ago

Wouldn't is_directory() be more appropriate?

Yeah, I suppose it would, have changed it.

#7 @nacin
10 years ago

I believe WordPress is spelled wrong here :-)

#8 @solarissmoke
10 years ago

Everyone's allowed to make that mistake once, right? :P

#9 @scribu
10 years ago

Since we're at it, how about checking for a .git directory too? :D

@solarissmoke
10 years ago

Add ABSPATH, use is_dir(), and capital P, dangit!

#10 @solarissmoke
10 years ago

There we go. I thought about customising the string for SVN and Git, but it seems like overkill.

#11 follow-up: @nacin
10 years ago

If we are to offer Git checkout detection, which I'm not inclined to do, I'd rather not combine the string.

Also, let's spell out "Subversion". My take: <strong>Warning:</strong> It appears that you are running Subversion checkout of WordPress. You may wish to keep WordPress up to date using Subversion instead.

Also, please don't replace patches -- just upload new ones.

#12 in reply to: ↑ 11 @solarissmoke
10 years ago

Also, please don't replace patches -- just upload new ones.

Okay.

#13 @dd32
10 years ago

If we are to offer Git checkout detection, which I'm not inclined to do

I agree here, Support the VCS we're using, we can't support every single VCS out there..

@dd32
10 years ago

#14 @dd32
10 years ago

attachment warning.jpg added

  • demo of 16216.3.diff for UI feedback.

#15 @jane
9 years ago

  • Milestone changed from 3.2 to Future Release

Missed freeze, punting.

#16 @helen
7 years ago

  • Focuses ui added
  • Keywords ui-feedback removed

#17 @helen
7 years ago

I know we disable auto updates when a VCS is detected - is that reusable here in any way?

#18 @chriscct7
5 years ago

  • Keywords needs-refresh added

This would make for a great enahancement

Note: See TracTickets for help on using tickets.