WordPress.org

Make WordPress Core

Opened 3 years ago

Last modified 3 months ago

#16216 new enhancement

Hide core updater if running an svn checkout

Reported by: johnjamesjacoby Owned by:
Milestone: Future Release Priority: normal
Severity: normal Version:
Component: Upgrade/Install Keywords: has-patch
Focuses: ui Cc:

Description

The logic with this patch is if you are running an svn checkout, do not display the core updater code and instead display a reminder.

Attachments (5)

running-svn-co.patch (3.6 KB) - added by johnjamesjacoby 3 years ago.
16216.diff (768 bytes) - added by solarissmoke 3 years ago.
16216.2.diff (820 bytes) - added by solarissmoke 3 years ago.
Add ABSPATH, use is_dir(), and capital P, dangit!
16216.3.diff (796 bytes) - added by solarissmoke 3 years ago.
warning.jpg (74.1 KB) - added by dd32 3 years ago.

Download all attachments as: .zip

Change History (22)

comment:1 koopersmith3 years ago

  • Component changed from General to Upgrade/Install
  • Keywords 3.2-early added
  • Milestone changed from Awaiting Review to Future Release

Having some sort of svn-specific behavior is definitely something we should do, but disabling the core updater entirely seems error prone. It should just be a warning.

comment:2 scribu3 years ago

  • Keywords 3.2-early removed
  • Milestone changed from Future Release to 3.2

What koop said.

Also, we should do the same per plugin/theme at some point.

Last edited 3 years ago by scribu (previous) (diff)

solarissmoke3 years ago

comment:3 solarissmoke3 years ago

  • Keywords has-patch added

How does this do for a simple warning?

comment:4 dd323 years ago

  • Keywords ui-feedback added

I'd throw an ABSPATH in there at least. Someone else might like to weigh in on the wording.

comment:5 scribu3 years ago

Wouldn't is_directory() be more appropriate?

comment:6 solarissmoke3 years ago

Wouldn't is_directory() be more appropriate?

Yeah, I suppose it would, have changed it.

comment:7 nacin3 years ago

I believe WordPress is spelled wrong here :-)

comment:8 solarissmoke3 years ago

Everyone's allowed to make that mistake once, right? :P

comment:9 scribu3 years ago

Since we're at it, how about checking for a .git directory too? :D

solarissmoke3 years ago

Add ABSPATH, use is_dir(), and capital P, dangit!

comment:10 solarissmoke3 years ago

There we go. I thought about customising the string for SVN and Git, but it seems like overkill.

comment:11 follow-up: nacin3 years ago

If we are to offer Git checkout detection, which I'm not inclined to do, I'd rather not combine the string.

Also, let's spell out "Subversion". My take: <strong>Warning:</strong> It appears that you are running Subversion checkout of WordPress. You may wish to keep WordPress up to date using Subversion instead.

Also, please don't replace patches -- just upload new ones.

solarissmoke3 years ago

comment:12 in reply to: ↑ 11 solarissmoke3 years ago

Also, please don't replace patches -- just upload new ones.

Okay.

comment:13 dd323 years ago

If we are to offer Git checkout detection, which I'm not inclined to do

I agree here, Support the VCS we're using, we can't support every single VCS out there..

dd323 years ago

comment:14 dd323 years ago

attachment warning.jpg added

  • demo of 16216.3.diff for UI feedback.

comment:15 jane3 years ago

  • Milestone changed from 3.2 to Future Release

Missed freeze, punting.

comment:16 helen3 months ago

  • Focuses ui added
  • Keywords ui-feedback removed

comment:17 helen3 months ago

I know we disable auto updates when a VCS is detected - is that reusable here in any way?

Note: See TracTickets for help on using tickets.