XMLRPC upload limits don't follow the same rules than the web interface

[koke]

If you have upload_space_check_disabled=true and fileupload_maxk=0, from the dahsboard (at least with the flash uploader) it means no limits, but from xmlrpc every upload fails

The first calls wp_handle_upload, which has a filter check_upload_size, and it checks the space limit check:

if ( get_site_option( 'upload_space_check_disabled' ) )
    return $file;

However, xmlrpc uses wp_upload_bits, which has a filter upload_is_file_too_big, which only checks fileupload_maxk

[nacin]

This looks good as a stopgap. I'd love to rewrite all of the upload-handling functions for multisite at the same time as ms-files.php going away.

[markjaquith]

In [21237]:

Do not block XML-RPC uploads when upload_space_check_disabled is true, regardless of fileupload_maxk value. props SergeyBiryukov. fixes #16217