WordPress.org

Make WordPress Core

Opened 10 years ago

Closed 5 years ago

Last modified 5 years ago

#16219 closed enhancement (fixed)

If you can edit comments on the post, 'Slow down Cowboy' shouldn't kick in

Reported by: nacin Owned by: garyc40
Milestone: 4.4 Priority: normal
Severity: normal Version:
Component: Comments Keywords: has-patch needs-testing dev-feedback
Focuses: Cc:

Description

Currently it's for administrators only. That doesn't make much sense for those who can already moderate comments.

Attachments (2)

garyc40.16219.diff (780 bytes) - added by garyc40 10 years ago.
check moderate_comments cap
garyc40.16219.2.diff (1.4 KB) - added by garyc40 10 years ago.
check is_user_logged_in() as well

Download all attachments as: .zip

Change History (8)

#1 @nacin
10 years ago

Also, we should only do an IP check if the user isn't logged in. When they are, we should do a user_id check instead. This is important for shared IPs, particularly conferences where a swarm may occur.

@garyc40
10 years ago

check moderate_comments cap

#2 @garyc40
10 years ago

  • Owner set to garyc40
  • Status changed from new to assigned

@garyc40
10 years ago

check is_user_logged_in() as well

#3 @garyc40
10 years ago

  • Keywords has-patch needs-testing added

#4 @chriscct7
6 years ago

  • Keywords dev-feedback added

Marking for dev review

#5 @wonderboymusic
5 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 34522:

Comments: in check_comment_flood_db(), don't throttle moderators. If the commenter is logged in, check against their user_id instead of comment_author_IP.

Throwback: "If you can edit comments on the post, 'Slow down Cowboy' shouldn't kick in."

Props garyc40, wonderboymusic.
Fixes #16219.

#6 @netweb
5 years ago

  • Milestone changed from Future Release to 4.4
Note: See TracTickets for help on using tickets.