WordPress.org

Make WordPress Core

Opened 10 years ago

Closed 6 years ago

#16223 closed enhancement (fixed)

post_class for public custom taxonomies

Reported by: sillybean Owned by: boonebgorges
Milestone: 4.2 Priority: normal
Severity: normal Version: 3.1
Component: Taxonomy Keywords: has-patch needs-testing
Focuses: template Cc:

Description

post_class() should include styles for custom taxonomies.

Attachments (3)

taxonomy-post-classes.diff (1.5 KB) - added by sillybean 10 years ago.
Adds post classes for public custom taxonomies
taxonomy-post-classes2.diff (1.5 KB) - added by sillybean 8 years ago.
Adds post classes for public custom taxonomies
taxonomy-post-classes3.diff​ (1.4 KB) - added by sillybean 7 years ago.

Download all attachments as: .zip

Change History (14)

#1 @nacin
10 years ago

  • Keywords needs-patch added
  • Milestone changed from Awaiting Review to Future Release

Nice enhancement. Can probably clean up the existing taxonomy code there in the process.

#2 @nacin
10 years ago

Going to leave the needs-patch on there. Let's reduce the code a bit.

We also need to check that we're hitting the cache on that.

#3 @sillybean
10 years ago

I thought so too, but it would change existing behavior, since tags print tag-name now and this would print post_tag-name. Could throw in an if just for tags, I guess.

#4 @nacin
10 years ago

Indeed.

#5 @sillybean
10 years ago

  • Keywords has-patch needs-testing added; needs-patch removed

Patch updated. This replaces the existing bits for categories and tags in a way that's consistent with the old behavior.

Not sure about the cache; this is more or less how it was done before.

@sillybean
10 years ago

Adds post classes for public custom taxonomies

#6 @sillybean
10 years ago

Finally found a moment to go through all the relevant functions, and it looks like they are hitting the cache whenever possible.

@sillybean
8 years ago

Adds post classes for public custom taxonomies

#7 @sillybean
8 years ago

Patch cleaned up and updated.

#8 @sillybean
7 years ago

Refreshed patch and cleaned up a taxonomy name/object error.

#9 @nacin
7 years ago

  • Component changed from Template to Taxonomy
  • Focuses template added

#10 @boonebgorges
6 years ago

  • Milestone changed from Future Release to 4.2

Following up: cache support looks good (demonstrated a unit test, coming up).

#11 @boonebgorges
6 years ago

  • Owner set to boonebgorges
  • Resolution set to fixed
  • Status changed from new to closed

In 31271:

Add classes for custom taxonomy terms in get_post_class().

Props sillybean.
Fixes #16223.

Note: See TracTickets for help on using tickets.