Stop Firebug from borking on missing convertEntities()

[mikeschinkel]

Firebug breaks on the following line which makes JavaScript debugging extremely tedious:

try{convertEntities(blahblah);}catch(e){};

I believe the following should accomplish the same thing without causing Firebug to bork:

if (typeof convertEntities=="function"){convertEntities(blahblah);}

I've attached a patch to change these.

This may already have been addressed by #15124 and if so forgive me but I could not tell for sure.

[mikeschinkel]

Changes call to convertEntities() so Firebug doesn't always break on those calls

[westi]

Which scripts?

[mikeschinkel]

Not sure, but if I use Firebug it always breaks on them. Can't you look at the patch to see the relevence?

[ocean90]

On which page you can see the error message? It means, that there is an error with the loading of the script. Your patch will not help then.

[mikeschinkel]

Replying to ocean90:

On which page you can see the error message? It means, that there is an error with the loading of the script. Your patch will not help then.

You misunderstand. Without the patch I get this when debugging with Firebug:

With the patch Firebug does not break on the error in every page load in the admin.

[westi]

Ok.

So quicktags translations then.

This is fixed in 3.1

Your patch is broken because it removes the calls to convertEntities if the function isn't there rather than fixing the fact that it isn't there.

Closing as a dupe of #15124

[mikeschinkel]

Thanks. I wasn't sure it #15124 fixed it or not as I mentioned. (BTW, I only removed the calls to convertEntities() because I was trying to mirror the existing behavior with having Firebug flag as an error.)