WordPress.org

Make WordPress Core

Opened 9 years ago

Closed 9 years ago

#16232 closed defect (bug) (fixed)

Permalink with Norwegian/Danish character 'ø'

Reported by: knutsp Owned by: azaozz
Milestone: 3.2 Priority: normal
Severity: normal Version: 3.0.4
Component: Permalinks Keywords: has-patch commit 3.2-early
Focuses: Cc:

Description

When a post title contains the 'ø' character, the post name and permalink is created without removing this character. The result is that the permalink in such cases are broken (not found).

Permalinks are set to /%year%/%monthnum%/%postname%/ and the server is IIS7 with rewrite module. Tested on 3.1-RC2-17283.

Attachments (1)

16232.diff (657 bytes) - added by scribu 9 years ago.

Download all attachments as: .zip

Change History (12)

@scribu
9 years ago

#1 @scribu
9 years ago

  • Keywords has-patch commit added

It seems there was a typo in remove_accents() which made the same character be checked twice.

#2 @nacin
9 years ago

  • Milestone changed from Awaiting Review to 3.1

#3 @westi
9 years ago

  • Keywords needs-testing 3.2-early added
  • Milestone changed from 3.1 to Future Release

This is not a regression - bug is very old

https://core.trac.wordpress.org/browser/trunk/wp-includes/functions-formatting.php?rev=2483

Moving to Future Release.

#4 @dd32
9 years ago

On Apache, in my testing, it doesn't 404, however the accented character does slip into the slug as urlencoded.

The attached patch fixes it and corrects it to o as expected for me.

#5 @dd32
9 years ago

  • Keywords needs-testing removed

#6 @scribu
9 years ago

Yes, it would have triggered 404s for old posts, if it weren't for [15929].

#7 @knutsp
9 years ago

  • Cc knut@… added

#8 @knutsp
9 years ago

Shouldn't the milestone for this be 3.2? I see a keyword 3.2-early.

#9 @nacin
9 years ago

  • Milestone changed from Future Release to 3.2

Lots of tickets were marked for 3.2 that were not actually slated for the milestone. Unfortunately, some code we were considering for better permalink sanitization did not make feature scope. Hoping for 3.3.

This is a pretty obvious typo though, so I can support it for 3.2.

#10 @knutsp
9 years ago

@nacin: May I still hope for 3.2?

#11 @azaozz
9 years ago

  • Owner set to azaozz
  • Resolution set to fixed
  • Status changed from new to closed

In [18159]:

Fix typo in remove_accents(), props scribu, fixes #16232

Note: See TracTickets for help on using tickets.