Make WordPress Core

Opened 13 years ago

Last modified 7 months ago

#16252 new feature request

Allow comment reparenting to fix poor threading

Reported by: otto42's profile Otto42 Owned by:
Milestone: Future Release Priority: normal
Severity: normal Version:
Component: Comments Keywords: has-patch needs-testing needs-refresh needs-design-feedback
Focuses: Cc:

Description

For the OCD among us, it would be super nice to be able to edit the comment_parent, to properly thread comments made in the wrong place/threading order.

Choose your own UI, but even just a numeric editor in the Quick Edit area would be a huge enhancement.

Attachments (4)

16252.diff (3.3 KB) - added by MattyRob 12 years ago.
16252v2.diff (3.3 KB) - added by MattyRob 12 years ago.
Collapsed.png (81.4 KB) - added by thijsvanloef 4 years ago.
Expanded.png (240.8 KB) - added by thijsvanloef 4 years ago.

Download all attachments as: .zip

Change History (32)

#1 @scribu
13 years ago

This was something that was worked on during GSoC 2010:

https://gsoc2010.wordpress.com/matt-harzewski-comments/

#2 @SergeyBiryukov
13 years ago

Perhaps something can be derived from existing plugins, like Move WordPress Comments by Nicolas Kuttler and my own Edit Parent Comment ID.

#3 @MattyRob
12 years ago

  • Keywords has-patch needs-testing dev-feedback added

I recently opened ticket 20292 which was closed as a duplicate of this ticket.

I've attached a patch file that adds a Comment Parent to the 'edit page' and allows a user with edit-comment privileges to enter a new integer into this field to update the database so enabling rethreading.

I've briefly tested it and it allow me to shuffle comments about changing their parents and even reverting the parent field to 0.

@MattyRob
12 years ago

#4 @MattyRob
12 years ago

  • Keywords dev-feedback removed

Updating patch against current trunk code

@MattyRob
12 years ago

#5 @SergeyBiryukov
12 years ago

  • Keywords ux-feedback added

#6 @travisnorthcutt
10 years ago

The Comment Hierarchy Adjust plugin may be of interest to folks with an interest in this ticket.

#7 @rachelbaker
9 years ago

  • Keywords needs-refresh added
  • Milestone changed from Awaiting Review to Future Release

This ticket was mentioned in Slack in #core-comments by ocean90. View the logs.


8 years ago

This ticket was mentioned in Slack in #design by karmatosed. View the logs.


7 years ago

#10 follow-up: @karmatosed
7 years ago

  • Keywords close added

This came up in ux-feedback triage and seems like a plugin would be better for this. Tentatively suggesting a close.

#11 in reply to: ↑ 10 @MattyRob
7 years ago

  • Keywords close removed

Replying to karmatosed:

This came up in ux-feedback triage and seems like a plugin would be better for this. Tentatively suggesting a close.

Having looked at the logs there didn't seem t be a great deal of discussion. What reasons are behind the thought process that this is 'better' handled by a plugin?

There are plugins available of course but the code overhead of loading an entire plugin to address what is covered in the patch above which contains 12 new lines of code seems like a good reason to have this in core. Additionally, there may be a good number of users looking for this who cannot find the plugins (as they haven't been updated for years) to deliver the functionality.

Is there any direct feedback on the way the current patch looks?

This ticket was mentioned in Slack in #design by karmatosed. View the logs.


6 years ago

#13 @joyously
6 years ago

I agree with MattyRob: this should be in core. Providing this rudimentary editing at least gives a user a way to solve a common problem. Plugins can then be used to enhance the experience.

This is what the patch looks like, but it needs a refresh.
https://s33.postimg.cc/pkz0q55db/Edit_Comment.jpg

#14 @joyously
6 years ago

Does this trigger the comment count updates to the posts?

This ticket was mentioned in Slack in #design by karmatosed. View the logs.


5 years ago

#16 @karmatosed
5 years ago

  • Keywords ux-feedback removed

#17 @Otto42
5 years ago

  • Keywords needs-design-feedback added

The numeric based UI is difficult. So, maybe somebody can think of a better way for this?

There's two problems. A) moving comments to the correct parents or to top level on the post, and B) moving comments to other posts. For the purposes of this ticket, we can probably just tackle the first one.

Any ideas on a better way to do it than magic numbers?

This ticket was mentioned in Slack in #design by estelaris. View the logs.


4 years ago

#19 @nrqsnchz
4 years ago

I agree that the numeric-based UI is difficult. I wonder if a select dropdown could be a better UI for this?

#20 @galbaras
4 years ago

https://wordpress.org/plugins/comments-advanced/ offers a much more user friendly UI for changing parent comment ID and more.

#21 @thijsvanloef
4 years ago

Hello!

@rolfsiebers, @uxkai and I have made some designs to tackle this issue as part of the Yoast Contributor Day. We would like to change the comment parents the same way you would change a menu in WP.

Our proposal allows the user to drag and drop the comments on a post to modify the order. You can access this page by clicking on the number of comments of a specific post on the Posts overview page.

We have included the screenshots in the attachments below and also added a live demo of what happens when you expand a comment.

Live Demo Page: https://www.sketch.com/s/3d71febc-5229-4120-b91b-2391c00633dc/a/nbJRLW/play

@thijsvanloef
4 years ago

#22 @galbaras
4 years ago

Looks like a great idea! Why not release it as a plugin first and then offer it to core fully tested?

This ticket was mentioned in Slack in #design by paaljoachim. View the logs.


4 years ago

This ticket was mentioned in Slack in #design by paaljoachim. View the logs.


4 years ago

This ticket was mentioned in Slack in #design by paaljoachim. View the logs.


4 years ago

#26 @paaljoachim
4 years ago

It would be great as you say @galbaras to first create a plugin and then modify to fit for core. (If it is a suitable UI feature to be included in core that is. Which we need to find out.)

@thijsvanloef could you create a plugin that we can try out?

Thanks!

#27 follow-up: @SergeyBiryukov
7 months ago

#59952 was marked as a duplicate.

#28 in reply to: ↑ 27 @llizard
7 months ago

Replying to SergeyBiryukov:

#59952 was marked as a duplicate.

I see that this initial ticket was created 13 years ago. That seems to be a very long time to be tracking the enhancement. Plugins for this enhancement were indeed created. However, plugins have a way of becoming obsolete as they are not kept up to date (searching for plugins to do this produced at least three that have not been tested for 6.4 and the message, "This plugin hasn't been tested with the latest 3 major releases of WordPress. It may no longer be maintained or supported and may have compatibility issues when used with more recent versions of WordPress").

I urge you to follow MattyRob's 6 year old advice:

There are plugins available of course but the code overhead of loading an entire plugin to address what is covered in the patch above which contains 12 new lines of code seems like a good reason to have this in core. Additionally, there may be a good number of users looking for this who cannot find the plugins (as they haven't been updated for years) to deliver the functionality.

Thank you.


Last edited 7 months ago by llizard (previous) (diff)
Note: See TracTickets for help on using tickets.