WordPress.org

Make WordPress Core

Changes between Version 8 and Version 20 of Ticket #16262


Ignore:
Timestamp:
01/19/11 23:49:59 (5 years ago)
Author:
nacin
Comment:

Modifying the 8 original points and adding point 9.

The implicit point 10 is that absolutely everything needs testing to ensure parity with 3.0.

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #16262

    • Property Priority changed from high to highest omg bbq
    • Property Keywords needs-patch added
    • Property Cc dkikizas@… added
  • Ticket #16262 – Description

    v8 v20  
    55Considerations: 
    66 
    7  1. Don't enqueue the JavaScript. 
     7 1. ~~Don't enqueue the JavaScript.~~ 
    88  
    9  2. Don't add the ajax nonce fields or any spinners. 
     9 2. ~~Don't add the ajax nonce fields or any spinners.~~ 
    1010  
    11  3. The top pagination input doesn't work. Solution is to only have the pagination input on the top. 
     11 3. ~~The top pagination input doesn't work. Solution is to only have the pagination input on the top.~~ 
    1212  
    13  4. The search box button shouldn't have a name. 
     13 4. ~~The search box button shouldn't have a name.~~ 
    1414  
    15  5. Sorting needs to kick back to page one. 
     15 5. ~~Sorting needs to kick back to page one.~~ 
    1616  
    17  6. Remove the filters in get_list_table() and merge get_list_table() and require_list_table() into a private _get_list_table(). Mark all tables as private. 
     17 6. ~~Remove the filters in get_list_table() and merge get_list_table() and require_list_table() into a private _get_list_table(). Mark all tables as private.~~ 
    1818 
    19  7. The architecture of the list tables needs to be reviewed this week for potential changes. Right now it isn't at the state where we are comfortable with release, especially when considering future requirements for backwards compatibility. By removing the JS for 3.1, we can spend the next week getting the classes exactly how we want them. 
     19 7. ''Postponed until 3.2.'' ~~The architecture of the list tables needs to be reviewed this week for potential changes. Right now it isn't at the state where we are comfortable with release, especially when considering future requirements for backwards compatibility. By removing the JS for 3.1, we can spend the next week getting the classes exactly how we want them.~~ 
    2020 
    21  8. edit-comments.dev.js and theme.dev.js both declare list-table a dependency. I don't see anything in theme.dev.js, but there are some things in edit-comments.dev.js that will need to be neutered.  
     21 8. ~~edit-comments.dev.js and theme.dev.js both declare list-table a dependency. I don't see anything in theme.dev.js, but there are some things in edit-comments.dev.js that will need to be neutered.~~ 
     22 
     23 9. The comment river needs to be fixed. 
    2224 
    2325Patch to follow shortly.