Make WordPress Core

Opened 13 years ago

Closed 10 years ago

#16271 closed enhancement (fixed)

Better handling of translating comments notification

Reported by: pavelevap's profile pavelevap Owned by:
Milestone: 4.1 Priority: normal
Severity: normal Version: 3.1
Component: I18N Keywords: has-patch commit
Focuses: Cc:

Description

Comments...

Author :
E-mail :
URL    :
Whois  :
Excerpt:

Pingback...

Website:
URL    :

It is not possible to manage translation with the same length of "Excerpt" and "Website" to have "URL" with the same number of spaces (required for "URL" which is the same for both types)...

BTW, Why it is "Excerpt" when there is the whole text of every comment in notification email?

Attachments (2)

16271.diff (3.8 KB) - added by solarissmoke 13 years ago.
16271.2.diff (3.9 KB) - added by DrewAPicture 10 years ago.
refresh

Download all attachments as: .zip

Change History (8)

#1 follow-up: @nacin
13 years ago

  • Milestone changed from Awaiting Review to Future Release

It probably used to be the excerpt. I've actually noticed this in the Notifly plugin, that this line just dumps comment_content, which isn't actually going to be formatted with things such as wpautop() (or at least nl2br, in the case of plain text emails).

It is possible to line these up in the translation, but it's probably a royal pain, as you have to do all the math yourself. We can probably do this with sprintf() padding. Or, we can probably kill it off, since so few probably use monospaced text in their email clients anymore.

@solarissmoke
13 years ago

#2 in reply to: ↑ 1 @solarissmoke
13 years ago

  • Keywords has-patch added

Replying to nacin:

Or, we can probably kill it off, since so few probably use monospaced text in their email clients anymore.

Patch does this.

I wonder how long before someone proposes using HTML..

#3 @chriscct7
10 years ago

  • Keywords needs-refresh added; has-patch removed

#4 @johnbillion
10 years ago

  • Milestone changed from Future Release to 4.1
  • Type changed from defect (bug) to enhancement

Somebody refresh this and it'll go in.

@DrewAPicture
10 years ago

refresh

#5 @DrewAPicture
10 years ago

  • Keywords has-patch commit added; needs-refresh removed

Refresh: 16271.2.diff

#6 @SergeyBiryukov
10 years ago

  • Resolution set to fixed
  • Status changed from new to closed

Fixed in [30015].

Note: See TracTickets for help on using tickets.