WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#16274 closed defect (bug) (fixed)

Remove WP_Cache non_existant_objects array

Reported by: duck_ Owned by: duck_
Milestone: 3.3 Priority: normal
Severity: normal Version:
Component: Cache API Keywords: has-patch needs-testing dev-feedback
Focuses: Cc:

Description

This was introduced back in [3021] "for options, which has its own notoptions cache these days" (ryan), to help reduce file system hits.

Right now it appears to just take up a bit of extra memory and cause incorrect figures on cache misses (assuming that we do want to report a 2nd request for an uncached item as a miss).

Noticed this as a result of investigation prior to #15812, I saw that stats was showing no increase in cache misses and I thought this a little strange but didn't question it too much.

Attachments (1)

16274.diff (1.9 KB) - added by duck_ 3 years ago.

Download all attachments as: .zip

Change History (5)

duck_3 years ago

comment:1 duck_3 years ago

  • Keywords has-patch needs-testing added

Initial patch by inspection, needs testing and feedback in case I missed a purpose.

comment:2 ryan3 years ago

Looks good.

comment:3 duck_3 years ago

  • Owner set to duck_
  • Resolution set to fixed
  • Status changed from new to closed

In [18682]:

Remove the non_existent_objects property from WP_Object_Cache. Fixes #16274.

comment:4 duck_3 years ago

  • Milestone changed from Future Release to 3.3
Note: See TracTickets for help on using tickets.