WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 2 years ago

Last modified 2 years ago

#16280 closed enhancement (invalid)

UI improvements to Themes API

Reported by: solarissmoke Owned by:
Milestone: Priority: normal
Severity: minor Version: 3.1
Component: Themes Keywords:
Focuses: Cc:

Description

Following on from #16132, some improvements to the Themes API UI. Here's a patch for one particular issue, but there may be more overhaul for WP 3.2

Attachments (1)

16280.diff (665 bytes) - added by solarissmoke 5 years ago.
Pass on original wp_error when http request fails

Download all attachments as: .zip

Change History (6)

@solarissmoke5 years ago

Pass on original wp_error when http request fails

comment:1 follow-up: @nacin5 years ago

I don't like this patch. As it is, the error message we're sending does very little to explain what went wrong. Providing the raw HTTP error might only make it worse.

These errors, strings, and UX need a real overhaul in 3.2.

comment:2 in reply to: ↑ 1 @solarissmoke5 years ago

Replying to nacin:

I don't like this patch. As it is, the error message we're sending does very little to explain what went wrong. Providing the raw HTTP error might only make it worse.

IMO "An unexpected HTTP error occurred" is far less helpful than the original HTTP error. But I agree that the whole thing needs improvement, so maybe minor tweaks isn't the way to go.

comment:3 @nacin5 years ago

  • Type changed from defect (bug) to enhancement

comment:4 @c3mdigital2 years ago

  • Resolution set to invalid
  • Status changed from new to closed

Theme UI overhaul covered in #19909 Any new issues should be in a new ticket.

comment:5 @SergeyBiryukov2 years ago

  • Milestone Awaiting Review deleted
Note: See TracTickets for help on using tickets.