WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 2 years ago

#16292 closed enhancement (wontfix)

Show theme path in ms-themes.php and ms-sites.php?action=editblog in network admin

Reported by: novasource Owned by: PeteMall
Milestone: Priority: normal
Severity: normal Version: 3.0.4
Component: Network Admin Keywords:
Focuses: multisite Cc:

Description

ms-themes.php and ms-sites.php?action=editblog leaves me guessing as to where each theme is. Please show the filesystem path, under the WordPress root folder, where the theme is.

I think this is especially important for network sites. At least in my case, we had to develop a few child themes that are subtly different from each other, and it would be helpful to immediately know where on the filesystem each theme is. Right now I have to inspect each child theme to remember which one corresponds to what I see in the themes list.

Attachments (2)

16292.patch (1.5 KB) - added by SergeyBiryukov 2 years ago.
16292.after.png (81.8 KB) - added by SergeyBiryukov 2 years ago.
With 16292.patch

Download all attachments as: .zip

Change History (20)

comment:1 nacin3 years ago

  • Milestone changed from Awaiting Review to Future Release
  • Owner set to PeteMall
  • Status changed from new to reviewing

comment:2 PeteMall2 years ago

  • Milestone Future Release deleted
  • Resolution set to wontfix
  • Status changed from reviewing to closed

comment:3 novasource2 years ago

  • Resolution wontfix deleted
  • Status changed from closed to reopened

Why?

comment:4 scribu2 years ago

  • Milestone set to Awaiting Review

Yes, some explanation is in order.

comment:5 Ipstenu2 years ago

  • Cc ipstenu@… added

SergeyBiryukov2 years ago

SergeyBiryukov2 years ago

With 16292.patch

comment:6 SergeyBiryukov2 years ago

  • Keywords has-patch added

16292.patch replicates the code from class-wp-themes-list-table.php. Added screenshot.

comment:7 PeteMall2 years ago

  • Keywords 2nd-opinion added

In my opinion, this adds information that is not needed by most of the end users. We already have filters in place if you want to add additional info to the themes lists table.

comment:8 scribu2 years ago

Thanks for the screenshots, Sergey.

I tend to agree with Pete. We're trying to make multisite more accesible to non-technical users. That's why we don't have a Post ID column anymore, for example.

Theme paths would be easier to scan if they were displayed in a separate column anyway.

Last edited 2 years ago by scribu (previous) (diff)

comment:9 scribu2 years ago

  • Milestone Awaiting Review deleted
  • Resolution set to wontfix
  • Status changed from reopened to closed

Alternatively, just give your child themes distinct names.

comment:10 novasource2 years ago

  • Resolution wontfix deleted
  • Status changed from closed to reopened
  • Summary changed from Show theme path in ms-themes.php and ms-sites.php?action=editblog to Show theme path in ms-themes.php and ms-sites.php?action=editblog in network admin

Wait a second, this isn't for "end users" or "non-technical users". This enhancement is for system administrators who deal with administration of a WordPress Network, which may have many themes. That's why I put this ticket in the Network Admin category. Sorry if my original post didn't make this clear.

It's difficult to figure out which team corresponds to what directory without showing it to us.

Version 0, edited 2 years ago by novasource (next)

comment:11 scribu2 years ago

  • Keywords needs-patch added; has-patch removed
  • Milestone set to Awaiting Review

Wait a second, this isn't for "end users" or "non-technical users". This enhancement is for system administrators who deal with administration of a WordPress Network, which may have many themes.

Exactly, the idea being that "end users" should not necessarily be sysadmins in order to administrate a WordPress network.

However, the case can be made that if the path is useful enough to be displayed in a single-site scenario, it's probably equally or even more useful in a multi-site scenario.

As I said in the previous comment, I think the path(s) should be displayed in a new column, in a more concise manner.

comment:12 PeteMall2 years ago

  • Keywords close added; needs-patch removed

After talking to Ryan in #wordpress-dev I would recommend closing this as a wontfix again. I don't think this makes sense for the majority of the users and you can use an existing filter to add the info in your use case.

Last edited 2 years ago by PeteMall (previous) (diff)

comment:13 follow-up: novasource2 years ago

After talking to Ryan in #wordpress-dev I would recommend closing this as a wontfix again. I don't think this makes sense for the majority of the users is already a filter in place for you to add the info in your use case.

Huh? I am asking for more information to be added to /wp-admin/network/themes.php, not for the ability to filter stuff.

comment:14 in reply to: ↑ 13 PeteMall2 years ago

You can use the theme_row_meta filter to add the info you want. Filter == Hook

comment:15 follow-up: novasource2 years ago

I'm confused. Apparently we want this product easy enough for non-technical people to use, and we do that by forcing these people to customize delivered PHP files to get information that will be essential for large WordPress networks with a lot of themes. I'm not seeing the logic in this.

comment:16 in reply to: ↑ 15 PeteMall2 years ago

Replying to novasource:

I'm confused. Apparently we want this product easy enough for non-technical people to use, and we do that by forcing these people to customize delivered PHP files to get information that will be essential for large WordPress networks with a lot of themes. I'm not seeing the logic in this.

I'm not asking you to hack any core files. I simply don't see the benefit (for the majority of the users) of adding this to the WordPress core. I understand your use case and that is why I suggested that you write a 10 line plugin to add the info you want.

comment:17 PeteMall2 years ago

For what it's worth, I manage several large WordPress networks and I don't think this is essential information.

comment:18 PeteMall2 years ago

  • Keywords 2nd-opinion close removed
  • Milestone Awaiting Review deleted
  • Resolution set to wontfix
  • Status changed from reopened to closed
Note: See TracTickets for help on using tickets.