Make WordPress Core

Opened 13 years ago

Closed 12 years ago

Last modified 9 years ago

#16302 closed defect (bug) (fixed)

Don't shout booleans

Reported by: westi's profile westi Owned by: westi's profile westi
Milestone: 3.4 Priority: normal
Severity: normal Version: 3.1
Component: Warnings/Notices Keywords: has-patch 3.2-early
Focuses: Cc:

Description

In a number of places in core WP or external libraries we shout our booleans as TRUE and FALSE instead of true and false.

We shouldn't in core WP.

No patch because search and replace can fixor this.

Attachments (2)

16302.diff (51.3 KB) - added by c3mdigital 13 years ago.
16302.null.diff (10.8 KB) - added by mfields 13 years ago.
Lowercase appropriate null values.

Download all attachments as: .zip

Change History (10)

#1 @nacin
13 years ago

also NULL vs null.

@c3mdigital
13 years ago

#2 @c3mdigital
13 years ago

  • Cc chris@… added
  • Keywords has-patch added; 3.2-early removed

#3 @SergeyBiryukov
13 years ago

  • Keywords 3.2-early added

#4 @nacin
13 years ago

Looks good.

Most of the external libraries should be avoided here. That includes class-ftp*.php and pclzip.php. kses is fine just because that's no longer really an external library in practice and should follow our standards.

Would also like to see NULL ucase'd in another patch.

#5 @mfields
13 years ago

I went through and lowercased all of the null values I came across. I ignored everything that looked like an external library and I did not touch any SQL. Please see 16302.null.diff

@mfields
13 years ago

Lowercase appropriate null values.

#6 @ryan
12 years ago

  • Milestone changed from Future Release to 3.4

#7 @ryan
12 years ago

  • Resolution set to fixed
  • Status changed from new to closed

In [19687]:

User lowercase true, false, null instead of uppercase. Props c3mdigital, mfields. fixes #16302

#8 @SergeyBiryukov
9 years ago

#14657 was marked as a duplicate.

Note: See TracTickets for help on using tickets.