WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 2 years ago

#16302 closed defect (bug) (fixed)

Don't shout booleans

Reported by: westi Owned by: westi
Milestone: 3.4 Priority: normal
Severity: normal Version: 3.1
Component: Warnings/Notices Keywords: has-patch 3.2-early
Focuses: Cc:

Description

In a number of places in core WP or external libraries we shout our booleans as TRUE and FALSE instead of true and false.

We shouldn't in core WP.

No patch because search and replace can fixor this.

Attachments (2)

16302.diff (51.3 KB) - added by c3mdigital 3 years ago.
16302.null.diff (10.8 KB) - added by mfields 3 years ago.
Lowercase appropriate null values.

Download all attachments as: .zip

Change History (9)

comment:1 nacin3 years ago

also NULL vs null.

c3mdigital3 years ago

comment:2 c3mdigital3 years ago

  • Cc chris@… added
  • Keywords has-patch added; 3.2-early removed

comment:3 SergeyBiryukov3 years ago

  • Keywords 3.2-early added

comment:4 nacin3 years ago

Looks good.

Most of the external libraries should be avoided here. That includes class-ftp*.php and pclzip.php. kses is fine just because that's no longer really an external library in practice and should follow our standards.

Would also like to see NULL ucase'd in another patch.

comment:5 mfields3 years ago

I went through and lowercased all of the null values I came across. I ignored everything that looked like an external library and I did not touch any SQL. Please see 16302.null.diff

mfields3 years ago

Lowercase appropriate null values.

comment:6 ryan2 years ago

  • Milestone changed from Future Release to 3.4

comment:7 ryan2 years ago

  • Resolution set to fixed
  • Status changed from new to closed

In [19687]:

User lowercase true, false, null instead of uppercase. Props c3mdigital, mfields. fixes #16302

Note: See TracTickets for help on using tickets.