get_taxonomy_labels() and _get_custom_object_labels() fail if $object->taxonomy is not array

[foofy]

$object->labels is always stdObject on the taxonomy objects created by WordPress, but the get_taxonomy_labels() and _get_custom_object_labels() functions expect it to be an array and will fail otherwise.

Casting to array works fine as the functions already convert back to stdObject when they're finished.

[foofy]

Casts $object->labels to array as it's what the functions expect it to be

[scribu]

Could you provide some steps to reproduce?

[nacin]

Sounds like you're using these functions manually, rather than letting WP call it during post type registration. Some of them are already marked private, perhaps the rest should be.

[foofy]

This will throw a fatal "cannot use object of type stdClass as array" error at line 1174 of wp-includes/post.php:

$tax = get_taxonomy('category'); 
$labels = get_taxonomy_labels($tax);

nacin: That makes sense for _get_custom_object_labels() but get_taxonomy_labels() is a public API function.

Hope this helps.

[nacin]

Replying to foofy:

nacin: That makes sense for _get_custom_object_labels() but get_taxonomy_labels() is a public API function.

It shouldn't be. You should do this instead:

$tax = get_taxonomy('category'); 
$labels = $tax->labels;

[foofy]

That makes sense. I feel that casting to array would avoid confusion later, though.

[scribu]

Should probably rename it to _get_taxonomy_labels() then?

[nacin]

Don't think that's entirely worth the effort. I'm just not sure why they were implicitly public functions to begin with.

I'm warming up to the initial patch here though.

[scribu]

Similar: #18257

[F J Kaiser]

​http://wordpress.stackexchange.com/questions/52023/get-post-type-plural/52035

[wonderboymusic]

Patch still applies, this is an easy fix

[wonderboymusic]

In 25553:

Add @access private to _get_custom_object_labels(), which was already implied by the dangling underscore. Cast $labels to array in get_taxonomy_labels() and _get_custom_object_labels().

Props nacin, foofy.
Fixes #16310.