WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 2 years ago

#16317 closed defect (bug) (fixed)

Twenty Ten: <pre> tag goes out of content area

Reported by: tapan.bojja Owned by: tapan.bojja
Milestone: 3.3 Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: has-patch
Focuses: Cc:

Description

If I enter a <pre> tag in content then it goes out of content area. I think for this css needs to be fix.
Kindly look in to the above issue.

Attachments (3)

20-Jan-11 7-11-34 PM.jpg (34.7 KB) - added by tapan.bojja 3 years ago.
16317.patch (355 bytes) - added by SergeyBiryukov 3 years ago.
16317-2.diff (354 bytes) - added by lancewillett 3 years ago.
Moved property into alpha order

Download all attachments as: .zip

Change History (20)

comment:1 Moskjis3 years ago

The theme you are using, is it Wordpress default one?
If it isn't, then this is the wrong place to create a ticket about it. You need to talk with the theme developer then.

comment:2 scribu3 years ago

  • Milestone Awaiting Review deleted
  • Resolution set to invalid
  • Status changed from new to closed

What Moskjis said.

SergeyBiryukov3 years ago

comment:3 SergeyBiryukov3 years ago

Actually it's the same in Twenty Ten. Attached the patch (just in case).

comment:4 dd323 years ago

  • Component changed from Formatting to Themes
  • Keywords has-patch added; Bug removed
  • Milestone set to Awaiting Review
  • Resolution invalid deleted
  • Status changed from closed to reopened

Confirmed the same thing in Twentyten.

Adding overflow: auto; causes a scrollbar to appear instead of the content continuing off the page.

comment:5 ocean903 years ago

  • Milestone changed from Awaiting Review to WordPress.org
  • Summary changed from <prre> tag issue to <pre> tag goes out of content area

comment:6 nacin3 years ago

  • Cc iandstewart lancewillett added

Want Lance or Ian to weigh in. If they like it, it goes in.

comment:7 lancewillett3 years ago

Patch looks good with one change: to conform to WP CSS standards the overflow property should go before the padding property (alphabetical order). See refreshed patch.

lancewillett3 years ago

Moved property into alpha order

comment:8 follow-up: nacin3 years ago

I'm not really a fan of alpha order and I know JohnONolan isn't either. I marked that Codex page as a draft a few months ago as they were never really discussed, and to thus allow for some discussion in the future.

comment:9 in reply to: ↑ 8 lancewillett3 years ago

Replying to nacin:

I'm not really a fan of alpha order and I know JohnONolan isn't either.

The strongest arguments for alpha order of properties is for readability and ease of debugging—two factors that are prevalent in WordPress code standards in general. Other CSS property ordering patterns are arbitrary and meaningful to the person who created them; alpha order is meaningful universally.

The drafted CSS coding standards should be discussed more, for sure, they are not perfect. But they are a start, and better than nothing. And we will be using them for the default theme's stylesheets.

Last edited 3 years ago by lancewillett (previous) (diff)

comment:10 follow-up: JohnONolan3 years ago

@lancewillet - There are multiple (valid) standpoints on this issue, but this isn't the place to discuss them :) The CSS coding standards in their current state are very much a working document. If you'd like to come along to UI group meeting - details on http://make.wordpress.org/ui - then I'd be happy put this up as an agenda item for discussion.

Version 0, edited 3 years ago by JohnONolan (next)

comment:11 in reply to: ↑ 10 lancewillett3 years ago

Replying to JohnONolan:

this isn't the place to discuss them

Agreed. I #blamenacin. :)

comment:12 SergeyBiryukov3 years ago

  • Keywords close added

This is probably fixed, considering the new default theme is Twenty Eleven, which already has overflow: auto; for <pre>. Or Twenty Ten still should be updated?

comment:13 SergeyBiryukov3 years ago

  • Keywords close removed

comment:15 SergeyBiryukov3 years ago

  • Component changed from Themes to Bundled Theme
  • Milestone changed from WordPress.org to 3.3
  • Summary changed from <pre> tag goes out of content area to Twenty Ten: <pre> tag goes out of content area

Not sure if "WordPress.org" is a proper milestone here, as Twenty Ten is still a bundled theme. Moving to 3.3 for consideration.

comment:16 nacin2 years ago

Running on WP.com. We'll take that as a go.

comment:17 nacin2 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In [19300]:

overflow:auto for pre tags in Twenty Ten. props SergeyBiryukov, fixes #16317.

Note: See TracTickets for help on using tickets.