Make WordPress Core

Opened 10 years ago

Closed 10 years ago

#16322 closed defect (bug) (fixed)

User network admin user-edit and site-users in the sites list table

Reported by: PeteMall Owned by: PeteMall
Milestone: 3.1 Priority: normal
Severity: normal Version: 3.1
Component: Multisite Keywords: has-patch commit
Focuses: Cc:


Attachments (3)

16322.diff (1.2 KB) - added by PeteMall 10 years ago.
16322.always-show-path-column.diff (657 bytes) - added by nacin 10 years ago.
16322.never-sort-plugin-name-column.diff (437 bytes) - added by nacin 10 years ago.

Download all attachments as: .zip

Change History (10)

10 years ago

#1 @nacin
10 years ago

  • Keywords commit added

Looks good, per earlier discussion as well.

#2 @nacin
10 years ago

Second patch, per IRC discussion. Don't let the 'Path' column be hidden in network/sites.php.

#3 @nacin
10 years ago

I'm just going to piggyback on this ticket for one last thing.

Per discussion with PeteMall and Jane in IRC, since sorting and pagination on the plugins screen is stateless, we should remove sorting on the plugin name column. Sorting, then making any action, will cause you to lose the action, which is lame.

Also lame, is that unlike on other screens that might be sorted by something else by default, the screen is already sorted by name. So the most this can do anyway is sort by name descending. Or as I like to call it, scroll to the bottom and use your imagination.

I'm not even sure why we have pagination on this screen either, if it's going to be 999 by default, but I'm sure someone has a use case.

Patch attached removes sorting on the name column.

#4 @ryan
10 years ago

All three look good.

#5 @nacin
10 years ago

(In [17336]) Link to site-users and network/user-edit on sites.php. props PeteMall, see #16322.

#6 @nacin
10 years ago

(In [17337]) Don't allow the 'Path' column on sites.php to be hidden. see #16322.

#7 @nacin
10 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [17338]) Don't sort the plugin name column. It doesn't stick between actions and is quite useless, so out it goes. fixes #16322.

Note: See TracTickets for help on using tickets.