Sorting is reset after searching

[scribu]

1. Go to /wp-admin/edit.php
2. Sort by title
3. Search for something

The search results are no longer sorted by title.

All list screens are affected.

[scribu]

for edit.php

[scribu]

16341.diff​ fixes the problem for edit.php, but the same needs to be done for all list screens.

[scribu]

I like Sergey's patch better.

Maybe we should make it a method of WP_List_Table, to avoid code duplication.

[ocean90]

Replying to scribu:

Maybe we should make it a method of WP_List_Table, to avoid code duplication.

+1

ocean90: scribu: Wouldn't be something like $wp_list_table->hidden_fields() nice?
scribu: exactly
ocean90: Which has some default fields and is extendable for example for the edit screen (post_type & post_status)
scribu: yep

[SergeyBiryukov]

16341.2.patch​ should do it for Posts, Media Library, Links, Pages, Comments and Users screens. Going to check Network screens.

[SergeyBiryukov]

16341.3.patch​ should do it for Network screens as well.

[SergeyBiryukov]

Fixed themes search on Edit Site screen

[nacin]

Not a fan of all the churn here. Let's just add the method and call it hidden_order_fields(), call it everywhere, and don't bother with any other iterations at this point.

[SergeyBiryukov]

Replying to nacin:

Let's just add the method and call it hidden_order_fields(), call it everywhere, and don't bother with any other iterations at this point.

Done.

[SergeyBiryukov]

16341.6.patch​ may have better formatting in hidden_order_fields().

[nacin]

We can also just sneak the logic into views() probably, as it's called on all the same pages. But thanks for the much simpler patch.

[SergeyBiryukov]

views() is currently called outside of the search forms. Not sure how it would help here.

[SergeyBiryukov]

Perhaps search_box() would be appropriate place?

[SergeyBiryukov]

OK, here's even more simple patch :)

[scribu]

I can agree with hidden_order_fields(), but slapping them onto search_box() is wrong, IMO.

[scribu]

From IRC:

(07:36:52 PM) nacin: scribu: the first thing I'm doing when 3.1 is released is rearchitecting this mess.

So let's go with 16341.7.patch​

[nacin]

(In [17353]) Add orderby and order hidden fields to each list form, to allow for state. props SergeyBiryukov, fixes #16341.