WordPress.org

Make WordPress Core

Opened 3 years ago

Last modified 4 months ago

#16345 reopened defect (bug)

Some submit buttons shouldn't have names

Reported by: nacin Owned by:
Milestone: Future Release Priority: normal
Severity: normal Version: 3.1
Component: Administration Keywords: dev-feedback
Focuses: Cc:

Description

Technically a regression due to the submit_button implementation. What happens instead is the URL gets polluted.

Noticed especially after we moved back to GET on a bunch of screens.

In these cases, we just need the form to be sent. Don't need the context info.

Attachments (3)

16345.diff (1.3 KB) - added by garyc40 3 years ago.
"Search Themes" and "Apply Filters" buttons don't need a name
16345.2.diff (2.3 KB) - added by garyc40 3 years ago.
"Search Users" and "Search Sites" on network dashboard don't need names either
16345-dashboard.diff (1.0 KB) - added by gizburdt 6 months ago.
Only dashboard.php needed to be changed

Download all attachments as: .zip

Change History (11)

comment:1 nacin3 years ago

(In [17349]) Use only an ID, no name, on the 'Filter' buttons on list screens. see #16345.

comment:2 nacin3 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [17352]) doaction buttons don't need a name, only an ID. fixes #16345.

comment:3 scribu3 years ago

Related: #16364

garyc403 years ago

"Search Themes" and "Apply Filters" buttons don't need a name

comment:4 garyc403 years ago

  • Keywords has-patch added
  • Resolution fixed deleted
  • Status changed from closed to reopened

"Search Themes" and "Apply Filters" button in wp-admin/themes.php don't need a name as well. Patch attached.

garyc403 years ago

"Search Users" and "Search Sites" on network dashboard don't need names either

comment:5 garyc403 years ago

These don't look like regressions though. The theme search form wasn't even there in 3.0.x .

Version 0, edited 3 years ago by garyc40 (next)

comment:6 markjaquith3 years ago

  • Milestone changed from 3.1 to Future Release

If they're not regressions, and don't cause problems, let's leave them alone for 3.1.

gizburdt6 months ago

Only dashboard.php needed to be changed

comment:7 gizburdt6 months ago

  • Keywords dev-feedback added; has-patch removed

comment:8 helen4 months ago

Still a thing?

Note: See TracTickets for help on using tickets.