WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 months ago

#16345 closed defect (bug) (fixed)

Some submit buttons shouldn't have names

Reported by: nacin Owned by: wonderboymusic
Milestone: 4.4 Priority: normal
Severity: normal Version: 3.1
Component: Administration Keywords: has-patch
Focuses: Cc:

Description

Technically a regression due to the submit_button implementation. What happens instead is the URL gets polluted.

Noticed especially after we moved back to GET on a bunch of screens.

In these cases, we just need the form to be sent. Don't need the context info.

Attachments (3)

16345.diff (1.3 KB) - added by garyc40 5 years ago.
"Search Themes" and "Apply Filters" buttons don't need a name
16345.2.diff (2.3 KB) - added by garyc40 5 years ago.
"Search Users" and "Search Sites" on network dashboard don't need names either
16345-dashboard.diff (1.0 KB) - added by gizburdt 2 years ago.
Only dashboard.php needed to be changed

Download all attachments as: .zip

Change History (13)

#1 @nacin
5 years ago

(In [17349]) Use only an ID, no name, on the 'Filter' buttons on list screens. see #16345.

#2 @nacin
5 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [17352]) doaction buttons don't need a name, only an ID. fixes #16345.

#3 @scribu
5 years ago

Related: #16364

@garyc40
5 years ago

"Search Themes" and "Apply Filters" buttons don't need a name

#4 @garyc40
5 years ago

  • Keywords has-patch added
  • Resolution fixed deleted
  • Status changed from closed to reopened

"Search Themes" and "Apply Filters" button in wp-admin/themes.php don't need a name as well. Patch attached.

@garyc40
5 years ago

"Search Users" and "Search Sites" on network dashboard don't need names either

#5 @garyc40
5 years ago

These don't look like regressions though. The theme search form wasn't even there in 3.0.x .

EDIT: Actually they're regressions, but as MarkJaquith said, they don't cause problems and we can leave them to 3.2

Last edited 5 years ago by garyc40 (previous) (diff)

#6 @markjaquith
5 years ago

  • Milestone changed from 3.1 to Future Release

If they're not regressions, and don't cause problems, let's leave them alone for 3.1.

@gizburdt
2 years ago

Only dashboard.php needed to be changed

#7 @gizburdt
2 years ago

  • Keywords dev-feedback added; has-patch removed

#8 @helen
2 years ago

Still a thing?

#9 @wonderboymusic
5 months ago

  • Keywords has-patch added; dev-feedback removed
  • Milestone changed from Future Release to 4.4

#10 @wonderboymusic
5 months ago

  • Owner set to wonderboymusic
  • Resolution set to fixed
  • Status changed from reopened to closed

In 34382:

Dashboard: 2 submit buttons don't need names.

Props garyc40, gizburdt.
Fixes #16345.

Note: See TracTickets for help on using tickets.