Dashboard widget preferences not being honored

[kpdesign]

On my dev Multisite install, I have set my preferences to only show the "Right Now" widget on the Network Admin screen. However, whenever I go to the Network Admin dashboard, all of the widgets are being displayed, regardless of what I've chosen (see screenshot).

I have to check all of the boxes, then uncheck them to make the other widgets disappear. Navigating away from the dashboard, then returning, all of the widgets are once again showing, and the checkboxes next to each one in the screen options panel are empty.

This only happens on the Network Admin dashboard; individual site dashboards retain their preferences properly.

[ocean90]

Related: #16238

It's happened:

Quote by ​ryan:

Let's make sure we don't end up with -network-network if the passed string is already suffixed.

​get_hidden_meta_boxes( $screen )

$screen is dashboard-network and through convert_to_screen() it becomes dashboard-network-network.

[nacin]

Oh man. Ryan's instincts trumped mine there.

[markjaquith]

Do we have something like this?

function add_suffix_once( $string, $suffix ) {
   return preg_replace( '#' . preg_quote( $suffix, '#' ) . '$#', '', $string ) . $suffix;
}

[kpdesign]

I've tested Sergey's patch on my dev install and it resolves the issue for me.

[markjaquith]

(In [17356]) Make sure we don't double-add -user or -network suffixes in convert_to_screen(). props SergeyBiryukov. fixes #16348