Context Navigation

← Previous Ticket
Next Ticket →

#16353 closed enhancement (wontfix)

Allow element between li's but not after final element in wp_list_bookmarks

Reported by:	in2thats12	Owned by:
Priority:	normal	Milestone:
Component:	General	Version:
Severity:	normal	Keywords:	has-patch close
Cc:		Focuses:

Description

Many times when displaying a list, one wants a separator between the list elements. Using the "after" arg would cause the separator to be displayed after the last element also.

To this end, I added the "li_between" option to the _walk_bookmarks function which places the contents of "li_between" after each list element, but not after the final list element.

Patch attached.

Attachments (1)

bookmark-template.patch (1.2 KB ) - added by in2thats12 15 years ago.: Add

Download all attachments as: .zip

Change History (5)

@in2thats12
15 years ago

Attachment bookmark-template.patch added

Add

#1 @scribu
15 years ago

Keywords has-patch added; has_patch removed

#2 @nacin
15 years ago

Keywords close added

This opens up a rabbit hole of inconsistency, with so many walkers and li's throughout WP.

This seems like something that should be done through CSS. Keep in mind you have last-child and plenty of other ways of selecting elements.

#3 @toscho
15 years ago

Cc info@… added

List items cannot have other siblings than list items. Anything else is invalid markup:

<ul>
  <li>
  <hr> <!-- invalid -->
  <li>
</ul>

Why should WP help to create broken HTML?

#4 @scribu
15 years ago

Milestone Awaiting Review
Resolution → wontfix
Status new → closed

Note: See TracTickets for help on using tickets.

Download in other formats:

Make WordPress Core