Abstract the word-trimming logic in wp_trim_excerpt

[nacin]

Currently, wp_trim_excerpt() takes a $text value, but if it exists, then all it does is apply the wp_trim_except filter. If it's empty, then $text becomes get_the_content(). All of the logic for actually splitting up words are trapped in this conditional.

I suggest a new function that wp_trim_excerpt can call. Here's the suggested function definition:

function wp_trim_words( $text, $length = 55, $more = '[...]' )

The length and more default values are what gets passed to the excerpt_length and excerpt_more filters. But I'd expect the filters themselves to remain in wp_trim_excerpt.

[nacin]

This also prevents the function from being used outside the loop. Kinda lame.

[scribu]

+1

[nacin]

Untested proof of concept.

[SergeyBiryukov]

Ah, never mind my patch then.

[nacin]

Either this or #12858 should be closed as a duplicate. #17030 was closed as a duplicate.

[dwenaus]

+1

[nacin]

This needs to happen for #16799.

[SergeyBiryukov]

Closed #17190 as a duplicate.

[duck_]

In [18732]:

Abstract word-trimming from wp_trim_excerpt() into wp_trim_words(). Props nacin. Fixes #16372.

[duck_]

Some tests: ​[UT441]