Make WordPress Core

Opened 16 years ago

Closed 15 years ago

#16380 closed defect (bug) (fixed)

Whitespace missing between strings

Reported by: johnbillion Owned by: ryan
Priority: normal Milestone: 3.3
Component: Administration Version: 3.1
Severity: trivial Keywords: has-patch
Cc: Focuses:

Description

If you bulk edit some posts and some (but not all) are locked due to being edited by another user, the resulting message lacks whitespace between the strings.

To reproduce, simply visit http://example.com/wp-admin/edit.php?updated=1&skipped=0&locked=1 .

Attachments (5)

capture.png (5.6 KB ) - added by johnbillion 16 years ago.
16380.patch (798 bytes ) - added by johnbillion 16 years ago.
patch
16380.diff (696 bytes ) - added by solarissmoke 16 years ago.
16380.2.patch (802 bytes ) - added by SergeyBiryukov 16 years ago.
16380.3.patch (802 bytes ) - added by SergeyBiryukov 15 years ago.

Download all attachments as: .zip

Change History (14)

@johnbillion
16 years ago

@johnbillion
16 years ago

patch

#1 @johnbillion
16 years ago

  • Version3.1

Patch. String change I'm afraid.

Also, there should be a Trac ticket severity lower than "trivial". Something like "Nobody is ever going to notice this and if they do they won't care anyway".

#2 @nacin
16 years ago

  • Milestone Awaiting ReviewFuture Release

This shouldn't need a string change. Leading and trailing whitespace should be avoided, especially for deliberate use. We can probably just echo a space somewhere.

@solarissmoke
16 years ago

#3 @solarissmoke
16 years ago

  • Keywords has-patch added

#4 @garyc40
16 years ago

I'd prefer to add the space after "% posts updated" rather than at the beginning of "%s items not updated".

There's always the case when all the posts that the user attempt to update are already being edited by someone. So your patch would result in an extra space at the beginning of the message.

#5 @solarissmoke
16 years ago

That makes sense

#6 @SergeyBiryukov
15 years ago

  • Milestone Future Release3.3

Refreshed for 3.3.

#7 @olleicua
15 years ago

Tested, certainly works.

#8 @olleicua
15 years ago

  • Cc olleicua@… added

#9 @ryan
15 years ago

  • Owner set to ryan
  • Resolutionfixed
  • Status newclosed

In [19259]:

Fix message concatentation. Remove no longer used 'posted' message. fixes #16380

Note: See TracTickets for help on using tickets.