WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 2 years ago

#16380 closed defect (bug) (fixed)

Whitespace missing between strings

Reported by: johnbillion Owned by: ryan
Milestone: 3.3 Priority: normal
Severity: trivial Version: 3.1
Component: Administration Keywords: has-patch
Focuses: Cc:

Description

If you bulk edit some posts and some (but not all) are locked due to being edited by another user, the resulting message lacks whitespace between the strings.

To reproduce, simply visit http://example.com/wp-admin/edit.php?updated=1&skipped=0&locked=1 .

Attachments (5)

capture.png (5.6 KB) - added by johnbillion 3 years ago.
16380.patch (798 bytes) - added by johnbillion 3 years ago.
patch
16380.diff (696 bytes) - added by solarissmoke 3 years ago.
16380.2.patch (802 bytes) - added by SergeyBiryukov 3 years ago.
16380.3.patch (802 bytes) - added by SergeyBiryukov 3 years ago.

Download all attachments as: .zip

Change History (14)

johnbillion3 years ago

johnbillion3 years ago

patch

comment:1 johnbillion3 years ago

  • Version set to 3.1

Patch. String change I'm afraid.

Also, there should be a Trac ticket severity lower than "trivial". Something like "Nobody is ever going to notice this and if they do they won't care anyway".

comment:2 nacin3 years ago

  • Milestone changed from Awaiting Review to Future Release

This shouldn't need a string change. Leading and trailing whitespace should be avoided, especially for deliberate use. We can probably just echo a space somewhere.

solarissmoke3 years ago

comment:3 solarissmoke3 years ago

  • Keywords has-patch added

comment:4 garyc403 years ago

I'd prefer to add the space after "% posts updated" rather than at the beginning of "%s items not updated".

There's always the case when all the posts that the user attempt to update are already being edited by someone. So your patch would result in an extra space at the beginning of the message.

SergeyBiryukov3 years ago

comment:5 solarissmoke3 years ago

That makes sense

SergeyBiryukov3 years ago

comment:6 SergeyBiryukov3 years ago

  • Milestone changed from Future Release to 3.3

Refreshed for 3.3.

comment:7 olleicua3 years ago

Tested, certainly works.

comment:8 olleicua3 years ago

  • Cc olleicua@… added

comment:9 ryan2 years ago

  • Owner set to ryan
  • Resolution set to fixed
  • Status changed from new to closed

In [19259]:

Fix message concatentation. Remove no longer used 'posted' message. fixes #16380

Note: See TracTickets for help on using tickets.