WordPress.org

Make WordPress Core

Opened 11 years ago

Closed 10 years ago

#16380 closed defect (bug) (fixed)

Whitespace missing between strings

Reported by: johnbillion Owned by: ryan
Milestone: 3.3 Priority: normal
Severity: trivial Version: 3.1
Component: Administration Keywords: has-patch
Focuses: Cc:

Description

If you bulk edit some posts and some (but not all) are locked due to being edited by another user, the resulting message lacks whitespace between the strings.

To reproduce, simply visit http://example.com/wp-admin/edit.php?updated=1&skipped=0&locked=1 .

Attachments (5)

capture.png (5.6 KB) - added by johnbillion 11 years ago.
16380.patch (798 bytes) - added by johnbillion 11 years ago.
patch
16380.diff (696 bytes) - added by solarissmoke 11 years ago.
16380.2.patch (802 bytes) - added by SergeyBiryukov 11 years ago.
16380.3.patch (802 bytes) - added by SergeyBiryukov 10 years ago.

Download all attachments as: .zip

Change History (14)

@johnbillion
11 years ago

@johnbillion
11 years ago

patch

#1 @johnbillion
11 years ago

  • Version set to 3.1

Patch. String change I'm afraid.

Also, there should be a Trac ticket severity lower than "trivial". Something like "Nobody is ever going to notice this and if they do they won't care anyway".

#2 @nacin
11 years ago

  • Milestone changed from Awaiting Review to Future Release

This shouldn't need a string change. Leading and trailing whitespace should be avoided, especially for deliberate use. We can probably just echo a space somewhere.

@solarissmoke
11 years ago

#3 @solarissmoke
11 years ago

  • Keywords has-patch added

#4 @garyc40
11 years ago

I'd prefer to add the space after "% posts updated" rather than at the beginning of "%s items not updated".

There's always the case when all the posts that the user attempt to update are already being edited by someone. So your patch would result in an extra space at the beginning of the message.

#5 @solarissmoke
11 years ago

That makes sense

#6 @SergeyBiryukov
10 years ago

  • Milestone changed from Future Release to 3.3

Refreshed for 3.3.

#7 @olleicua
10 years ago

Tested, certainly works.

#8 @olleicua
10 years ago

  • Cc olleicua@… added

#9 @ryan
10 years ago

  • Owner set to ryan
  • Resolution set to fixed
  • Status changed from new to closed

In [19259]:

Fix message concatentation. Remove no longer used 'posted' message. fixes #16380

Note: See TracTickets for help on using tickets.