Width of Site Address input box in network/site-new.php

[garyc40]

See screenshots

[garyc40]

fix box width

[markjaquith]

How it looked in 3.0.4

[garyc40]

also fix the width of "Domain" box in network/site-info.php when editing a site that's not the main site

[helenyhou]

Sounds good. Should it be given any particular size or is auto good enough?

[honeysilvas]

Before - Add Site

[honeysilvas]

After - Add Site

[honeysilvas]

Before - Site Info

[honeysilvas]

After - Site Info

[honeysilvas]

The refreshed patch

[jeremyfelt]

Thanks for the patch @honeysilvas! It's looking good.

A couple thoughts:

• It looks like forms.css may be a better fit than edit.css for these rules. Maybe with a new section for network admin?
• Would it make sense to add .site-info-php and .site-new-php before .form-field? I could be overthinking it too.
• We should leave the ID for blog_last_updated and blog_registered alone in this patch. While it would be great with - instead, there may be somebody already styling with a custom stylesheet based on these IDs.

[honeysilvas]

Thank you for your feedback, Jeremy. Here's the updated patch.

Regarding:

Would it make sense to add .site-info-php and .site-new-php before .form-field? I could be overthinking it too.

It's fine with me either way. Just let me know which you prefer and I can incorporate it into the patch.

Some questions about inline styles:

In site-info.php, line 47, there is an inline style (style="margin-bottom:5px;") that I can move to the CSS file. Since I am editing that line anyway, should I move that inline style or just leave it?

<input name="blog[path]" type="text" id="path" value="<?php echo esc_attr( $details->path ) ?>" style="margin-bottom:5px;" />

In site-info.php, line 48, there is another inline style (style="width:20px;") that I can remove. It's barely noticeable, but the width makes the checkbox look weird.

<input type="checkbox" style="width:20px;" name="update_home_url" value="update" <?php if ( get_option( 'siteurl' ) == untrailingslashit( get_blogaddress_by_id ($id ) ) || get_option( 'home' ) == untrailingslashit( get_blogaddress_by_id( $id ) ) ) echo 'checked="checked"'; ?> /> <?php _e( 'Update <code>siteurl</code> and <code>home</code> as well.' ); ?>

I am not sure if these are within the scope of this patch. I can leave these alone but I can also easily incorporate them into the patch. What do you think?

[ocean90]

Replying to honeysilvas:

I am not sure if these are within the scope of this patch.

That's fine. Feel free to move these to forms.css.

[ocean90]

honeysilvas, you should leave a comment on the ticket when you attach a file to a ticket. Attachments doesn't trigger a notifcation.

[honeysilvas]

ocean90, thanks for letting me know. I did not know that. :)

[jeremyfelt]

Thanks for the updates @honeysilvas. I'll get this in tonight.

[ocean90]

The patch still needs some styles for smaller screens. The section should also be placed above the media queries.

[honeysilvas]

Here's the updated patch. Thanks!

[honeysilvas]

I updated the styles for smaller screens and moved the section above the media queries.

Let me know if there's anything else.

[ocean90]

In 30578:

Network Admin: Improve width of input fields on Add New Site and Edit Site screens.

props honeysilvas.
fixes #16383.