WordPress.org

Make WordPress Core

Opened 10 years ago

Closed 6 years ago

#16383 closed defect (bug) (fixed)

Width of Site Address input box in network/site-new.php

Reported by: garyc40 Owned by: honeysilvas
Milestone: 4.1 Priority: normal
Severity: normal Version: 3.1
Component: Networks and Sites Keywords: has-patch good-first-bug
Focuses: multisite, administration Cc:

Description

See screenshots

Attachments (13)

16383.diff (1.4 KB) - added by garyc40 10 years ago.
fix box width
before.png (14.4 KB) - added by garyc40 10 years ago.
after.png (13.6 KB) - added by garyc40 10 years ago.
3.0.4.png (28.5 KB) - added by markjaquith 10 years ago.
How it looked in 3.0.4
16383.2.diff (2.1 KB) - added by garyc40 10 years ago.
also fix the width of "Domain" box in network/site-info.php when editing a site that's not the main site
add-site-before.png (51.6 KB) - added by honeysilvas 6 years ago.
Before - Add Site
add-site-after.png (51.4 KB) - added by honeysilvas 6 years ago.
After - Add Site
site-info-before.png (60.0 KB) - added by honeysilvas 6 years ago.
Before - Site Info
site-info-after.png (59.6 KB) - added by honeysilvas 6 years ago.
After - Site Info
16383.3.patch (5.2 KB) - added by honeysilvas 6 years ago.
The refreshed patch
16383.4.patch (5.4 KB) - added by honeysilvas 6 years ago.
16383.5.patch (5.8 KB) - added by honeysilvas 6 years ago.
16383.6.patch (6.3 KB) - added by honeysilvas 6 years ago.
Here's the updated patch. Thanks!

Download all attachments as: .zip

Change History (28)

@garyc40
10 years ago

fix box width

@garyc40
10 years ago

@garyc40
10 years ago

#1 @garyc40
10 years ago

  • Keywords has-patch added

@markjaquith
10 years ago

How it looked in 3.0.4

@garyc40
10 years ago

also fix the width of "Domain" box in network/site-info.php when editing a site that's not the main site

#2 @markmcwilliams
10 years ago

  • Keywords ui-feedback added

#3 @helenyhou
8 years ago

  • Component changed from UI to Network Admin
  • Keywords needs-refresh added; ui-feedback removed
  • Milestone changed from Awaiting Review to Future Release

Sounds good. Should it be given any particular size or is auto good enough?

#4 @nacin
7 years ago

  • Component changed from Network Admin to Networks and Sites
  • Focuses administration added

#5 @jeremyfelt
6 years ago

  • Keywords good-first-bug added

@honeysilvas
6 years ago

Before - Add Site

@honeysilvas
6 years ago

After - Add Site

@honeysilvas
6 years ago

Before - Site Info

@honeysilvas
6 years ago

After - Site Info

@honeysilvas
6 years ago

The refreshed patch

This ticket was mentioned in Slack in #core by honeysilvas. View the logs.


6 years ago

#7 @jeremyfelt
6 years ago

  • Milestone changed from Future Release to 4.1

Thanks for the patch @honeysilvas! It's looking good.

A couple thoughts:

  • It looks like forms.css may be a better fit than edit.css for these rules. Maybe with a new section for network admin?
  • Would it make sense to add .site-info-php and .site-new-php before .form-field? I could be overthinking it too.
  • We should leave the ID for blog_last_updated and blog_registered alone in this patch. While it would be great with - instead, there may be somebody already styling with a custom stylesheet based on these IDs.

#8 follow-up: @honeysilvas
6 years ago

Thank you for your feedback, Jeremy. Here's the updated patch.

Regarding:

Would it make sense to add .site-info-php and .site-new-php before .form-field? I could be overthinking it too.

It's fine with me either way. Just let me know which you prefer and I can incorporate it into the patch.

Some questions about inline styles:

In site-info.php, line 47, there is an inline style (style="margin-bottom:5px;") that I can move to the CSS file. Since I am editing that line anyway, should I move that inline style or just leave it?

<input name="blog[path]" type="text" id="path" value="<?php echo esc_attr( $details->path ) ?>" style="margin-bottom:5px;" />

In site-info.php, line 48, there is another inline style (style="width:20px;") that I can remove. It's barely noticeable, but the width makes the checkbox look weird.

<input type="checkbox" style="width:20px;" name="update_home_url" value="update" <?php if ( get_option( 'siteurl' ) == untrailingslashit( get_blogaddress_by_id ($id ) ) || get_option( 'home' ) == untrailingslashit( get_blogaddress_by_id( $id ) ) ) echo 'checked="checked"'; ?> /> <?php _e( 'Update <code>siteurl</code> and <code>home</code> as well.' ); ?>

I am not sure if these are within the scope of this patch. I can leave these alone but I can also easily incorporate them into the patch. What do you think?

@honeysilvas
6 years ago

#9 in reply to: ↑ 8 @ocean90
6 years ago

Replying to honeysilvas:

I am not sure if these are within the scope of this patch.

That's fine. Feel free to move these to forms.css.

@honeysilvas
6 years ago

#10 @ocean90
6 years ago

  • Keywords needs-refresh removed
  • Owner set to honeysilvas
  • Status changed from new to assigned

honeysilvas, you should leave a comment on the ticket when you attach a file to a ticket. Attachments doesn't trigger a notifcation.

#11 @honeysilvas
6 years ago

ocean90, thanks for letting me know. I did not know that. :)

#12 @jeremyfelt
6 years ago

  • Type changed from enhancement to defect (bug)

Thanks for the updates @honeysilvas. I'll get this in tonight.

#13 @ocean90
6 years ago

The patch still needs some styles for smaller screens. The section should also be placed above the media queries.

@honeysilvas
6 years ago

Here's the updated patch. Thanks!

#14 @honeysilvas
6 years ago

I updated the styles for smaller screens and moved the section above the media queries.

Let me know if there's anything else.

#15 @ocean90
6 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 30578:

Network Admin: Improve width of input fields on Add New Site and Edit Site screens.

props honeysilvas.
fixes #16383.

Note: See TracTickets for help on using tickets.